Add result aggregation for query templates #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, the result model probably needs to be changed, so that it includes the relation between query templates and their instances. |
# Conflicts: # src/main/java/org/aksw/iguana/cc/query/QueryData.java # src/main/java/org/aksw/iguana/cc/query/handler/QueryHandler.java # src/main/java/org/aksw/iguana/cc/query/list/QueryList.java # src/test/java/org/aksw/iguana/cc/query/QueryDataTest.java
bigerl
requested changes
Oct 30, 2024
src/main/java/org/aksw/iguana/cc/query/handler/QueryHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/aksw/iguana/cc/query/handler/QueryHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/aksw/iguana/cc/tasks/impl/StresstestResultProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/aksw/iguana/cc/query/handler/QueryHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/aksw/iguana/cc/query/handler/QueryHandler.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Bigerl <bigerl@mail.upb.de>
This reverts commit 8489f6e.
|
The version check test seems to be broken, I have to fix it soon. Also I haven't extracted the header writing part to a separate file yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new default behaviour is, that each result from the instances of a query template will be counted as the result of the query template. This is done by forcing the query instances to use the id of the query template in the results.
The query templates are considered as queries as well, but they won't be executed.
The ids of those queries that won't be presented in the results (instance queries if
individualResultsis turned on, query templates otherwise) will be shifted to the right, outside of the range of the number of queries whose results will be presented.The serialization of the query instaces needed to be changed as well, so that the query instances can be mapped back to their
templates.
The query handler also needs to differentiate between the number of executable queries and the number of queries, that
will be presented in the results, otherwise, too few queries might be executed.
Todo: