Fixes: #304 : Add Test Cases for SpaceMismatch Error in pallet-network-score
#534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @vatsa287, |
vatsa287
requested changes
Dec 16, 2024
vatsa287
reviewed
Dec 17, 2024
|
@huamanraj No changes are required at |
|
@vatsa287 please review this!! |
vatsa287
requested changes
Dec 27, 2024
|
@vatsa287 please review! is it good? |
vatsa287
reviewed
Jan 5, 2025
vatsa287
previously approved these changes
Jan 6, 2025
Signed-off-by: Aman Raj <113578582+huamanraj@users.noreply.github.com>
huamanraj
force-pushed
the
my-branch-2024-12-13
branch
from
e5b103d to
32077f8
Compare
@vatsa287 Fixed!! |
huamanraj
changed the title
SpaceMismatch Error in pallet-network-score
|
@amarts please merge this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new test cases for handling the SpaceMismatch error within the pallet-network-score module. It addresses the requirement specified in #304 to validate that the SpaceMismatch error is correctly returned across all applicable function calls.
Key Changes:
Added a test case,
test_space_mismatch_in_rating_registration, to assert the correct handling of the SpaceMismatch error when there is a mismatch between the space digest and authorization ID during the rating registration process.The test ensures that the error is properly triggered when attempting to register ratings with incorrect space authorization.
All functions that return the SpaceMismatch error have been validated, ensuring that this error is caught in various scenarios.
Implementation Details:
Followed the structure and approach of existing test cases such as
test_duplicate_member_requestin pallet-network-membership.Focused on simulating space mismatch scenarios in rating registration and confirming that the correct error is returned.
Expected Outcome:
The test should assert that the SpaceMismatch error is returned properly in all relevant calls.
The validation covers all functions returning this error, either through a single comprehensive test case or multiple focused test cases.