feat(sharing-dialog): allow sharing dashboards without cascading shar…

…ing (#1674)
dhis2 · Feb 26, 2025 · 18af4f7 · 18af4f7
1 parent d68c85c
commit 18af4f7
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 1 deletion.
diff --git a/components/sharing-dialog/src/sharing-dialog.js b/components/sharing-dialog/src/sharing-dialog.js
@@ -91,6 +91,7 @@ export const SharingDialog = ({
     initialSharingSettings = defaultInitialSharingSettings,
     dataTest = 'dhis2-uicore-sharingdialog',
     dataSharing = false,
+    cascadeDashboardSharing = true,
 }) => {
     const { show: showError } = useAlert((error) => error, { critical: true })
     const mappedInitialSharingSettings = mapInitialSharingSettings(
@@ -161,6 +162,7 @@ export const SharingDialog = ({
                         onChange={() => {}}
                         onRemove={() => {}}
                         dataSharing={dataSharing}
+                        cascadeDashboardSharing={cascadeDashboardSharing}
                     />
                 </Modal>
             </FetchingContext.Provider>
@@ -224,6 +226,7 @@ export const SharingDialog = ({
                     onChange={onChange}
                     onRemove={onRemove}
                     dataSharing={dataSharing}
+                    cascadeDashboardSharing={cascadeDashboardSharing}
                 />
             </Modal>
         </FetchingContext.Provider>
@@ -235,6 +238,8 @@ SharingDialog.propTypes = {
     id: PropTypes.string.isRequired,
     /** The type of object to share */
     type: PropTypes.oneOf(DIALOG_TYPES_LIST).isRequired,
+    /** Whether to show the tabbed sharing interface for applying cascade sharing of dashboard items */
+    cascadeDashboardSharing: PropTypes.bool,
     /** Whether to expose the ability to set data sharing (in addition to metadata sharing) */
     dataSharing: PropTypes.bool,
     dataTest: PropTypes.string,

diff --git a/components/sharing-dialog/src/sharing-dialog.prod.stories.js b/components/sharing-dialog/src/sharing-dialog.prod.stories.js
@@ -259,6 +259,18 @@ ForDashboardWithCascadeSharingPartialSuccess.storyName =
     'For dashboard with cascading sharing partial success'
 ForDashboardWithCascadeSharingPartialSuccess.args = { type: 'dashboard' }
 
+export const ForDashboardWithoutCascadeSharing = (args) => (
+    <CustomDataProvider data={{ ...dashboardData }}>
+        <SharingDialog {...args} />
+    </CustomDataProvider>
+)
+ForDashboardWithoutCascadeSharing.storyName =
+    'For dashboard without cascading sharing (embedded dashboard)'
+ForDashboardWithoutCascadeSharing.args = {
+    type: 'dashboard',
+    cascadeDashboardSharing: false,
+}
+
 export const RTL = (args) => {
     useEffect(() => {
         document.body.dir = 'rtl'

diff --git a/components/sharing-dialog/src/tabs/tabbed-content.js b/components/sharing-dialog/src/tabs/tabbed-content.js
@@ -24,10 +24,11 @@ export const TabbedContent = ({
     onChange,
     onRemove,
     dataSharing,
+    cascadeDashboardSharing,
 }) => {
     const [activeTabIndex, setActiveTabIndex] = useState(0)
 
-    if (type === DIALOG_TYPES.DASHBOARD) {
+    if (type === DIALOG_TYPES.DASHBOARD && cascadeDashboardSharing) {
         return (
             <>
                 <TabBar>
@@ -91,6 +92,7 @@ export const TabbedContent = ({
 
 TabbedContent.propTypes = {
     allowPublicAccess: PropTypes.bool.isRequired,
+    cascadeDashboardSharing: PropTypes.bool.isRequired,
     dataSharing: PropTypes.bool.isRequired,
     groups: PropTypes.arrayOf(
         PropTypes.shape({

diff --git a/components/sharing-dialog/types/index.d.ts b/components/sharing-dialog/types/index.d.ts
@@ -93,6 +93,7 @@ export interface SharingDialogProps {
      */
     initialSharingSettings?: SharingDialogInitialSharingSettings
     dataSharing?: boolean
+    cascadeDashboardSharing?: boolean
     onClose?: ModalOnCloseEventHandler
     onError?: (error: any) => void
     onSave?: () => void