Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [DHIS2-18978] Back buttons duplicate breadcrumbs #3957

Merged
merged 6 commits into from
Feb 10, 2025

Conversation

henrikmv
Copy link
Contributor

@henrikmv henrikmv commented Feb 7, 2025

DHIS2-18978:

  • Removes the Back to all stages and events and the Show all events button.
  • Changes Cypress test to use the breadcrumb for navigating.

@henrikmv henrikmv marked this pull request as ready for review February 7, 2025 10:21
@henrikmv henrikmv requested a review from a team as a code owner February 7, 2025 10:21
Copy link

github-actions bot commented Feb 7, 2025

Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
5 New issues
5 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@henrikmv henrikmv added e2e-tests and removed testing labels Feb 8, 2025
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥳

Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.42,2.41.4,2.40.8,2.39.9 versions

@henrikmv henrikmv merged commit 7c36218 into master Feb 10, 2025
65 of 66 checks passed
@henrikmv henrikmv deleted the hv/fix/DHIS2-18978_BackButtonsDublicatesBreadcrumbs branch February 10, 2025 14:09
dhis2-bot added a commit that referenced this pull request Feb 10, 2025
## [101.25.4](v101.25.3...v101.25.4) (2025-02-10)

### Bug Fixes

* [DHIS2-18978] Back buttons duplicate breadcrumbs ([#3957](#3957)) ([7c36218](7c36218))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.25.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants