Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [DHIS2-18673] prevent saving in profile widget when validation errors are present #3943

Merged

Conversation

alaa-yahia
Copy link
Member

@alaa-yahia alaa-yahia commented Jan 20, 2025

Implements DHIS2-18673

@alaa-yahia alaa-yahia requested a review from a team as a code owner January 20, 2025 09:10
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 👏 !

Copy link

Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.42,2.41.4,2.40.7,2.39.9 versions

@alaa-yahia alaa-yahia merged commit e341070 into master Jan 28, 2025
46 checks passed
@alaa-yahia alaa-yahia deleted the DHIS2-18673-profile-widget-valudations-doesnot-prevent-save branch January 28, 2025 08:23
dhis2-bot added a commit that referenced this pull request Jan 28, 2025
## [101.23.1](v101.23.0...v101.23.1) (2025-01-28)

### Bug Fixes

* [DHIS2-18673] prevent saving in profile widget when validation errors are present ([#3943](#3943)) ([e341070](e341070))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.23.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants