-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [DHIS2-16782] Changelog sorting and filtering by user and data item #3934
base: master
Are you sure you want to change the base?
feat: [DHIS2-16782] Changelog sorting and filtering by user and data item #3934
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @henrikmv, it looks good overall, I just added 2 small comments.
src/core_modules/capture-core/components/WidgetsChangelog/common/hooks/useListDataValues.js
Outdated
Show resolved
Hide resolved
src/core_modules/capture-core/components/WidgetsChangelog/common/hooks/useChangelogData.js
Outdated
Show resolved
Hide resolved
…ChangelogSortingAndFilteringByUserAndDataItem
🚀 Deployed on https://deploy-preview-3934.capture.netlify.dhis2.org |
...modules/capture-core/components/WidgetsChangelog/common/ChangelogFilterBar/DropdownFilter.js
Show resolved
Hide resolved
...les/capture-core/components/WidgetsChangelog/common/ChangelogFilterBar/ChangelogFilterBar.js
Outdated
Show resolved
Hide resolved
...les/capture-core/components/WidgetsChangelog/common/ChangelogFilterBar/ChangelogFilterBar.js
Show resolved
Hide resolved
...ore_modules/capture-core/components/WidgetsChangelog/common/Changelog/Changelog.container.js
Outdated
Show resolved
Hide resolved
...les/capture-core/components/WidgetsChangelog/common/ChangelogFilterBar/ChangelogFilterBar.js
Outdated
Show resolved
Hide resolved
This reverts commit 5b2b511.
…eringByUserAndDataItem
…eringByUserAndDataItem
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
DHIS2-16782:
User
andData item
Data item
(For the attributes: DataElement and Field)