Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [DHIS2-18325] Show orgunit selector in the new event form #3879

Merged
merged 34 commits into from
Jan 24, 2025

Conversation

henrikmv
Copy link
Contributor

@henrikmv henrikmv commented Nov 11, 2024

DHIS2-18325

  • Integrated an organisational unit selector within the Report tab.

  • Made the organisational unit field mandatory and implemented validation within the form.

  • Blocked changes to the organisational unit field in the context selector on the "New Event" page by setting the new isReadOnly property to true.

  • Enabled automatic selection of the organisational unit in the "New Event" form when an organisational unit is selected in the context selector.

  • Removed Cypress tests for clearing the organisational unit on the "New Event" page since this action is now blocked.

  • The rules engine was managed by @JoakimSM.

@henrikmv henrikmv marked this pull request as ready for review December 10, 2024 16:58
@henrikmv henrikmv requested a review from a team as a code owner December 10, 2024 16:58
@henrikmv henrikmv added testing and removed testing labels Dec 10, 2024
Copy link

github-actions bot commented Dec 11, 2024

@henrikmv henrikmv marked this pull request as draft December 11, 2024 11:48
@henrikmv henrikmv removed the testing label Dec 11, 2024
@JoakimSM JoakimSM force-pushed the hv/feat/DHIS2-18325_showOrgUnitSelectorInNewEventForm branch from b0eea46 to a4bf697 Compare January 20, 2025 15:15
@henrikmv henrikmv added e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud testing and removed testing labels Jan 21, 2025
@henrikmv henrikmv added testing and removed e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud testing labels Jan 23, 2025
Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.42,1.41.4,2.40.7.23.9.9 versions

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@henrikmv henrikmv added testing and removed testing labels Jan 24, 2025
@henrikmv henrikmv merged commit f07b4d4 into master Jan 24, 2025
41 of 42 checks passed
@henrikmv henrikmv deleted the hv/feat/DHIS2-18325_showOrgUnitSelectorInNewEventForm branch January 24, 2025 15:23
dhis2-bot added a commit that referenced this pull request Jan 24, 2025
# [101.23.0](v101.22.0...v101.23.0) (2025-01-24)

### Features

* [DHIS2-18325] Show orgunit selector in the new event form ([#3879](#3879)) ([f07b4d4](f07b4d4))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants