feat: [DHIS2-15391] preview images in working lists and on enrollment dashboard #3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🚀 Deployed on https://deploy-preview-3546--dhis2-capture.netlify.app |
JoakimSM
reviewed
Mar 4, 2024
Comment on lines
32
to
35
| value: convertServerToClient(value, type), | ||
| urlPath: `/trackedEntityInstances/${tei.trackedEntity}/${id}/image`, | ||
| urlPath: featureAvailable(FEATURES.trackerImageEndpoint) ? | ||
| `/tracker/trackedEntities/${tei.trackedEntity}/attributes/${id}/image?program=${programId}&dimension=small` : | ||
| `/trackedEntityInstances/${tei.trackedEntity}/${id}/image`, |
There was a problem hiding this comment.
Can we only add the urlPath if it is an image? Would improve readability quite a bit.
Also, in
previewUrl and fullSizedUrl instead of the single url and remove the replace statement in PreviewImage.component. Would be more robust that way and the "UI-library" will not be responsible for computing URLs.
geethaalwan
approved these changes
Mar 4, 2024
JoakimSM
approved these changes
Mar 4, 2024
|
Tested successfully on 2.41 version |
dhis2-bot
added a commit
that referenced
this pull request
Mar 5, 2024
# [100.61.0](v100.60.0...v100.61.0) (2024-03-05) ### Features * [DHIS2-15391] preview images in working lists and on enrollment dashboard ([#3546](#3546)) ([191c22f](191c22f))
|
🎉 This PR is included in version 100.61.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature summary: