Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DHIS2-16764][DHIS2-16759][DHIS2-16781] Changelog #3540

Merged
merged 18 commits into from
Mar 5, 2024
Merged

feat: [DHIS2-16764][DHIS2-16759][DHIS2-16781] Changelog #3540

merged 18 commits into from
Mar 5, 2024

Conversation

eirikhaugstulen
Copy link
Contributor

This ticket implements both types of changelogs. (Will detail more later. API support is not there for TE changelog).

@eirikhaugstulen eirikhaugstulen requested a review from a team as a code owner February 28, 2024 06:49
@eirikhaugstulen eirikhaugstulen mentioned this pull request Feb 28, 2024
Closed
simonadomnisoru
simonadomnisoru reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @eirikhaugstulen,
It looks like the Viewlog for the events programs is missing. Is this on purpose for this first iteration?
Thanks!

src/core_modules/capture-core/components/WidgetProfile/WidgetProfile.component.js Outdated Show resolved Hide resolved
...s/capture-core/components/WidgetEventEdit/EditEventDataEntry/EditEventDataEntry.container.js Outdated Show resolved Hide resolved
src/core_modules/capture-core/components/WidgetsChangelog/Changelog/Changelog.component.js Outdated Show resolved Hide resolved
..._modules/capture-core/components/WidgetsChangelog/common/ChangelogTable/ChangelogTableRow.js Outdated Show resolved Hide resolved
src/core_modules/capture-core/converters/clientToList.js Show resolved Hide resolved
src/core_modules/capture-core/components/WidgetProfile/WidgetProfile.component.js Outdated Show resolved Hide resolved
@eirikhaugstulen
Copy link
Contributor Author

Thanks everyone for the discussions! Everything should be implemented now 😎

JoakimSM
JoakimSM reviewed Feb 29, 2024
View reviewed changes
Copy link
Member

@JoakimSM JoakimSM left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial thoughts:

Can we have two consumer-facing Widgets, WidgetEventChangelog and WidgetTrackedEntityChangelog, as suggested by the design? The props will be a little bit different for the two. You will need a programId prop for the TrackedEntityChangelog that is not needed for the EventChangelog (it's missing currently, but you need it for the api request), and it will also be easier for the consumer with eventId and trackedEntityId instead of the generic entityId.

src/core_modules/capture-core/components/WidgetsChangelog/Changelog/Changelog.container.js Outdated Show resolved Hide resolved
JoakimSM
JoakimSM reviewed Mar 1, 2024
View reviewed changes
Copy link
Member

@JoakimSM JoakimSM left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks really great @eirikhaugstulen 👍 Need to fix the programId comment, the other comment about the close callback is just a NIT that we don't have to do (but feel free to do it if think it is a good idea)

src/core_modules/capture-core/components/WidgetsChangelog/common/hooks/useChangelogData.js Show resolved Hide resolved
src/core_modules/capture-core/components/WidgetsChangelog/common/hooks/useChangelogData.js Show resolved Hide resolved
src/core_modules/capture-core/components/WidgetsChangelog/common/hooks/useChangelogData.js Show resolved Hide resolved
JoakimSM
JoakimSM approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@JoakimSM JoakimSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@eirikhaugstulen
Merge remote-tracking branch 'origin/master' into eh/feat/DHIS2-16764…
7d5c042 
…-tracked-entity-changelog

# Conflicts:
#	src/core_modules/capture-core-utils/featuresSupport/support.js
#	src/core_modules/capture-core/components/Pages/EnrollmentEditEvent/EnrollmentEditEventPage.types.js
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-3540--dhis2-capture.netlify.app

@karolinelien
Copy link
Contributor

Tested on:

Version | 2.41-SNAPSHOT -- | -- Build revision | f23e034 Build date | March 4, 2024 at 16:39

@JoakimSM JoakimSM added testing and removed testing labels Mar 5, 2024
@JoakimSM JoakimSM added testing and removed testing labels Mar 5, 2024
@JoakimSM JoakimSM merged commit fa54ee4 into master Mar 5, 2024
37 checks passed
@JoakimSM JoakimSM deleted the eh/feat/DHIS2-16764-tracked-entity-changelog branch March 5, 2024 21:33
dhis2-bot added a commit that referenced this pull request Mar 5, 2024
@dhis2-bot
chore(release): cut 100.65.0 [skip release]
444682e 
# [100.65.0](v100.64.0...v100.65.0) (2024-03-05)

### Features

* [DHIS2-16764][DHIS2-16759][DHIS2-16781] Changelog ([#3540](#3540)) ([fa54ee4](fa54ee4))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.65.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superskip superskip superskip left review comments

@JoakimSM JoakimSM JoakimSM approved these changes

@simonadomnisoru simonadomnisoru simonadomnisoru approved these changes

Assignees
No one assigned
Labels
released testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eirikhaugstulen @karolinelien @dhis2-bot @simonadomnisoru @JoakimSM @superskip