fix: [DHIS2-16318] enrollment page url management #3522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/core_modules/capture-core/components/Pages/Enrollment/EnrollmentPage.epics.js
Outdated
Show resolved
Hide resolved
|
Thanks for the review @simonadomnisoru!
|
simonadomnisoru
approved these changes
Feb 20, 2024
|
🚀 Deployed on https://deploy-preview-3522--dhis2-capture.netlify.app |
geethaalwan
approved these changes
Feb 27, 2024
dhis2-bot
added a commit
that referenced
this pull request
Feb 27, 2024
## [100.57.3](v100.57.2...v100.57.3) (2024-02-27) ### Bug Fixes * [DHIS2-16318] enrollment page url management ([#3522](#3522)) ([0abec43](0abec43))
|
🎉 This PR is included in version 100.57.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DHIS2-16318
This is a complete rewrite of the enrollment page epics. Their primary function is (still) to handle changes in the url.
The url of the enrollment page can be navigated by tweaking four parameters:
enrollmentId,programId,teiIdandorgUnitId. Their effect can briefly be described as follows.enrollmentIdtriggers an update of theteiIdandprogramId. The new id's are those associated with the specified enrollment. Any existing values ofteiIdandprogramIdin the url will be overwritten.teiIdtriggers downloading of tracked entity type and tei display name.teiIdorprogramIdtriggers enrollment data to be downloaded and causes automatic switching of selected orgUnit to the associated program owner, provided the user has capture scope access to this orgUnit.orgUnitIdtriggers no new actions (hence no epics for this).There is some additional complexity related to management of the status of the few asynchronous calls that is going on in the epics. For instance, if a new
teiIdandprogramIdis being fetched from the server due to updatedenrollmentId, we will in the meantime avoid initiating any async request depending onteiIdandprogramId.Further complexity comes from error handling and dealing with blanking of ids.