feat: [DHIS2-14799] Working list for follow up #3521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eirikhaugstulen IMHO this feature needs more design clarification. Some doubts that came to mind:
Thanks! |
…_WorkingListForFollowUp # Conflicts: # i18n/en.pot
|
Hey @simonadomnisoru! Thanks for the review. I had some discussions with Joakim and Karoline, and the consensus was that we put in |
...e_modules/capture-core/components/WorkingLists/TeiWorkingLists/Setup/hooks/useFiltersOnly.js
Show resolved
Hide resolved
…_WorkingListForFollowUp # Conflicts: # i18n/en.pot
JoakimSM
reviewed
Feb 19, 2024
There was a problem hiding this comment.
Couple of comments that might or might not be in the back of your head:
- It seems like boolean value type filters have changed from a multi-select to a single-select. Great if we can keep multi-select for the value type.
- Boolean value type filters are stored as a string representation in Redux when you add the filter (
workingListsMeta/teiList/filters/). When the filter is loaded from a template, it is stored as a javascript boolean primitive. Great if we can always save them as javascript booleans. The idea was to store the "client-formatted" value here, and it would be great to continue doing so (boolean for boolean value type, number for number/integer value type, ISO-string for date etc. See the converters formToClient, clientToServer etc.)
The follow-up part seems to work well with an updated backend 👍
…_WorkingListForFollowUp # Conflicts: # i18n/en.pot
JoakimSM
approved these changes
Mar 5, 2024
|
🚀 Deployed on https://deploy-preview-3521--dhis2-capture.netlify.app |
dhis2-bot
added a commit
that referenced
this pull request
Mar 6, 2024
# [100.66.0](v100.65.0...v100.66.0) (2024-03-06) ### Features * [DHIS2-14799] Working list for follow up ([#3521](#3521)) ([0ad3891](0ad3891))
|
🎉 This PR is included in version 100.66.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TECH-summary:
The design doc also mentions that this should be available to select in the ColumnSelector, but I'm not sure if this makes sense. FollowUp is an attribute of the enrollment itself, meaning we have no good way of displaying this. Not sure what you think.