Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [DHIS2-16499] Handle different API response format #3517

Merged
merged 5 commits into from
Feb 1, 2024
Merged

fix: [DHIS2-16499] Handle different API response format #3517

merged 5 commits into from
Feb 1, 2024

Conversation

simonadomnisoru
Copy link
Contributor

@simonadomnisoru simonadomnisoru commented Jan 29, 2024 •
edited
Loading

DHIS2-16499

Tech summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-3517--dhis2-capture.netlify.app

@simonadomnisoru simonadomnisoru marked this pull request as ready for review January 29, 2024 15:07
@simonadomnisoru simonadomnisoru requested a review from a team as a code owner January 29, 2024 15:07
@simonadomnisoru simonadomnisoru changed the title fix: [DHIS2-16499] Handle importable exporter payload fix: [DHIS2-16499] Handle payload with requested entities field Jan 29, 2024
@simonadomnisoru simonadomnisoru changed the title fix: [DHIS2-16499] Handle payload with requested entities field fix: [DHIS2-16499] Handle response with requested entities field Jan 29, 2024
@simonadomnisoru simonadomnisoru changed the title fix: [DHIS2-16499] Handle response with requested entities field fix: [DHIS2-16499] Handle different API response format Jan 29, 2024
eirikhaugstulen
eirikhaugstulen approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@eirikhaugstulen eirikhaugstulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! App seemed to work as expected.

@eirikhaugstulen eirikhaugstulen mentioned this pull request Jan 30, 2024
Merged
geethaalwan
geethaalwan approved these changes Feb 1, 2024
View reviewed changes
Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.41,2.40.3,2.39.5,2.38.7 versions

@simonadomnisoru simonadomnisoru merged commit 206d56c into master Feb 1, 2024
36 of 38 checks passed
@simonadomnisoru simonadomnisoru deleted the DHIS2-16499 branch February 1, 2024 15:02
dhis2-bot added a commit that referenced this pull request Feb 1, 2024
@dhis2-bot
chore(release): cut 100.53.1 [skip release]
0858a28 
## [100.53.1](v100.53.0...v100.53.1) (2024-02-01)

### Bug Fixes

* [DHIS2-16499] Handle different API response format ([#3517](#3517)) ([206d56c](206d56c))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.53.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eirikhaugstulen eirikhaugstulen eirikhaugstulen approved these changes

@geethaalwan geethaalwan geethaalwan approved these changes

Assignees
No one assigned
Labels
released testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simonadomnisoru @dhis2-bot @eirikhaugstulen @geethaalwan