fix: [DHIS2-16084] Filter unidirectional relationship types #3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superskip
reviewed
Dec 6, 2023
...e-core/components/WidgetsRelationship/common/RelationshipsWidget/useGroupedLinkedEntities.js
Show resolved
Hide resolved
...ules/capture-core/components/WidgetsRelationship/common/useRelationships/useRelationships.js
Show resolved
Hide resolved
| @@ -137,7 +137,7 @@ const getLinkedEntityData = (apiLinkedEntity, relationshipCreatedAt, pendingApiR | |||
| return null; | |||
| }; | |||
|
|
|||
| const determineLinkedEntity = (fromEntity, toEntity, sourceId) => { | |||
| export const determineLinkedEntity = (fromEntity: ApiLinkedEntity, toEntity: ApiLinkedEntity, sourceId: string) => { | |||
There was a problem hiding this comment.
Might as well add the return type too?
There was a problem hiding this comment.
Do we usually type return types? It looks like it's being inferred, but added it just to be safe.
...etsRelationship/WidgetTrackedEntityRelationship/WidgetTrackedEntityRelationship.component.js
Show resolved
Hide resolved
|
Thanks for the review, @superskip! Should be fixed now 🙌 |
JoakimSM
approved these changes
Dec 12, 2023
superskip
approved these changes
Dec 12, 2023
|
🚀 Deployed on https://deploy-preview-3477--dhis2-capture.netlify.app |
geethaalwan
approved these changes
Dec 14, 2023
eirikhaugstulen
deleted the
eh/fix/DHIS2-16084_Filter-unidirectional-relations
branch
dhis2-bot
added a commit
that referenced
this pull request
Dec 14, 2023
## [100.47.3](v100.47.2...v100.47.3) (2023-12-14) ### Bug Fixes * [DHIS2-16084] Filter unidirectional relationship types ([#3477](#3477)) ([3579fc0](3579fc0))
|
🎉 This PR is included in version 100.47.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tech summary:
to-sideTest case: https://dhis2.atlassian.net/browse/DHIS2-16239