From 9ecce0d815f7efe00bb8dc387ce4a1e21c83fffe Mon Sep 17 00:00:00 2001 From: Kai Vandivier Date: Sat, 2 Nov 2024 14:57:15 +0100 Subject: [PATCH] docs: remove "noticed in __ app" mentions --- docs/migration/v12.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/migration/v12.md b/docs/migration/v12.md index 9611e0e4..89776ecc 100644 --- a/docs/migration/v12.md +++ b/docs/migration/v12.md @@ -316,9 +316,9 @@ By default, Vite adds its environment variables to the [`import.meta.env` object Here are some edge cases that were encountered when upgrading some apps with the new platform version: -- There is a bug in Vite: importing from a directory, e.g. `'./app/'` where we would assume to get `./app/index.[jt]s`, can incorrectly resolve to a file with a similar name to the directory, e.g. `./App.tsx`. I see this as a bug with Vite, but as a workaround, file and dir names can be changed so they don't conflict. Noticed in the Maintenance app beta. +- There is a bug in Vite: importing from a directory, e.g. `'./app/'` where we would assume to get `./app/index.[jt]s`, can incorrectly resolve to a file with a similar name to the directory, e.g. `./App.tsx`. I see this as a bug with Vite, but as a workaround, file and dir names can be changed so they don't conflict. - If you're using `identity-obj-proxy` in your test config, make sure you add it to the project's dependencies. Previously, some apps got away with using the proxy without an explicitid dependency because the package is a dependency of `react-scripts` -- You may see some build warnings coming from the `mathjs` package. Upgrading to a recent version of `mathjs` will handle these warnings. Noticed in analytics app (the analytics library has a dependency on `mathjs`) +- You may see some build warnings coming from the `mathjs` package. Upgrading to a recent version of `mathjs` will handle these warnings. ## Full list of breaking changes and deprecations @@ -337,7 +337,7 @@ The most likely and impactful breaking changes have been described in detail abo 9. An `App.jsx` entrypoint is no longer quietly added if a plugin entrypoint is defined or for a defined but empty entrypoints object 10. Plugins and apps are started together in the same process on the same port 11. Custom `index.html` files are no longer supported -12. `import * as MyClass from 'my-module'` is now more restrictive, and may break in some cases. So far, changing the import to `import MyClass from 'my-module'` has fixed it. DOMPurify is one example case, noticed in the Login App +12. `import * as MyClass from 'my-module'` is now more restrictive, and may break in some cases. So far, changing the import to `import MyClass from 'my-module'` has fixed it. DOMPurify is one example case. ### Deprecations