Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the hamburger menu size and content to improve visibility and user experience. #73

Closed

Conversation

PraveenUppar
Copy link
Contributor

Pull Request Template for GSoC 2024

Related Issue

Description of Changes

  • Corrected issues where the menu content was not displaying properly, ensuring that all options are now visible.
  • Hamburger Menu Size Adjustment

Type of Pull Request

  • Bug Fix
  • New Feature
  • Performance Improvement
  • Documentation Update
  • Code Refactoring
  • Security Enhancement
  • Other (Specify): UI/UX

Screenshots / Demo (if applicable)

Screenshot 2024-10-06 002429

Checklist for Contributor

  • I have reviewed my code before submission.
  • I have read and followed the project's Contribution Guidelines.
  • I have tested the code thoroughly.
  • I have attached related issue numbers, screenshots, or videos (if applicable).
  • I have added comments to my code where necessary for clarity.
  • I have checked the existing code base and my changes do not introduce any breaking changes.
  • My PR addresses only one issue; I have created separate PRs for other issues.
  • I have ensured that the PR does not include unrelated files.
  • I am mindful of the project's coding standards and best practices.

Additional Information

N/A

Contribution Guidelines Reminder

Thank you for contributing to our project! Please ensure you follow the guidelines below:

Contribution Levels

  1. Task Categories:

    • Basic Tasks: Primarily focused on small changes like minor bug fixes, documentation improvements, and unit testing. Labeled as Easy.
    • Intermediate Tasks: Moderate-level tasks that involve enhancing existing features, code refactoring, or performance improvements. Labeled as Medium.
    • Advanced Tasks: Complex tasks like building new features, significant refactoring, or critical bug fixes. Labeled as Hard.
  2. Acknowledging Effort:

    • Exceptional contributions will be recognized with a higher contribution level if substantial effort and innovation are demonstrated.

Review Process

  • PRs will be reviewed by the maintainers, and feedback will be provided. Contributors should address feedback promptly and resubmit the PR if necessary.

  • Contributors are encouraged to participate in the review process of other PRs for community growth.

We appreciate your time and effort in improving this project and look forward to your valuable contributions!

Copy link

vercel bot commented Oct 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
station-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2024 7:06pm

Copy link
Contributor

github-actions bot commented Oct 5, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@dhairyagothi
Copy link
Owner

@PraveenUppar increase width of hamburger previous one is good . No need of this changes .

If you can make any changes make it .

Don't use px instead of vw . It removes responsiveness

@dhairyagothi dhairyagothi added question Further information is requested wontfix This will not be worked on labels Oct 6, 2024
@PraveenUppar
Copy link
Contributor Author

The problem with the previous hamburger was that it was taking up more space on the homepage which was not a good user experience if you don't like the changes made in the hamburger sizing I will resubmit the PR with hamburger font size and visibility changes only

@dhairyagothi
Copy link
Owner

The problem with the previous hamburger was that it was taking up more space on the homepage which was not a good user experience if you don't like the changes made in the hamburger sizing I will resubmit the PR with hamburger font size and visibility changes only

I think previous one is good . Let it be . I am doing some changes you check it once then make a PR

@PraveenUppar
Copy link
Contributor Author

ok thank you for your feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants