Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language selector overlapping removed : #467 done #471

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

VinayLodhi1712
Copy link
Contributor

Pull Request Template for GSoC 2024

Related Issue

closes: #467 done

Description of Changes

  1. The language selector box overlapping does not collide with the navbar so i make changes.
  2. and in responsive also it does not collide so i make changes in navbar.jsx
  3. And the search icon is also overlapping with the navbar in responsive mode so make changes in navbar.jsx

Type of Pull Request

  • [X ] Bug Fix

Screenshots / Demo (if applicable)

20241030235726.mp4

Checklist for Contributor

  • [X ] I have reviewed my code before submission.
  • [X ] I have read and followed the project's Contribution Guidelines.
  • [X ] I have tested the code thoroughly.
  • [X ] I have attached related issue numbers, screenshots, or videos (if applicable).
  • [ X] I have added comments to my code where necessary for clarity.
  • [X ] I have checked the existing code base and my changes do not introduce any breaking changes.
  • [ X] My PR addresses only one issue; I have created separate PRs for other issues.
  • [ X] I have ensured that the PR does not include unrelated files.
  • [X ] I am mindful of the project's coding standards and best practices.

Additional Information

[Include any additional context or relevant information that may help in reviewing this PR.]

Contribution Guidelines Reminder

Thank you for contributing to our project! Please ensure you follow the guidelines below:

Contribution Levels

  1. Task Categories:

    • Basic Tasks: Primarily focused on small changes like minor bug fixes, documentation improvements, and unit testing. Labeled as Easy.
    • Intermediate Tasks: Moderate-level tasks that involve enhancing existing features, code refactoring, or performance improvements. Labeled as Medium.
    • Advanced Tasks: Complex tasks like building new features, significant refactoring, or critical bug fixes. Labeled as Hard.
  2. Acknowledging Effort:

    • Exceptional contributions will be recognized with a higher contribution level if substantial effort and innovation are demonstrated.

Review Process

  • PRs will be reviewed by the maintainers, and feedback will be provided. Contributors should address feedback promptly and resubmit the PR if necessary.

  • Contributors are encouraged to participate in the review process of other PRs for community growth.

We appreciate your time and effort in improving this project and look forward to your valuable contributions!

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
station-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 6:34pm
station-guide-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 6:34pm

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@dhairyagothi dhairyagothi added enhancement New feature or request level 2 25 Points Issue gssoc-ext GSSOX'24 Extended hacktoberfest-accepted Hacktoberfest hacktoberfest issue under hacktoberfest labels Oct 31, 2024
@dhairyagothi dhairyagothi merged commit 6c5b560 into dhairyagothi:main Oct 31, 2024
5 checks passed
Copy link
Contributor

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to Station Guide. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc-ext GSSOX'24 Extended hacktoberfest issue under hacktoberfest hacktoberfest-accepted Hacktoberfest level 2 25 Points Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On responsiveness navbar open then select language and search button is overlapped with navbar.
2 participants