-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed hamburger menu ,colour, search icon, greeting phrase #37
Fixed hamburger menu ,colour, search icon, greeting phrase #37
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just do this change other thing is perfect
frontend/src/Pages/Herosection.css
Outdated
} | ||
|
||
width: 100vw; | ||
overflow: hidden; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove it
Do overflow-x : hidden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Perfect to go now @1-SubhamSingh good job |
🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to Station Guide. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀 |
Thanks for the PR and also for updating the label to level 2 :)) |
Related Issue
Issue : fix the hamburger menu
Fixes : #9
Before_fixes.mp4
Description of Changes
Changed the colour of the menu button , enhanced the animation of the menu button.
Fixed the bottom of the hamburger menu , adjusted its size by blocking its overflow.
Positioned the greeting phrase in the center to look good.
Moved the search button to the right with some padding which looks good on different screen sizes.
No fixed the top because the search icon would have hidden due to that.
After_fixes2.mp4
Type of Pull Request
Checklist for Contributor
use'X' in [ ] to check it .