Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed hamburger menu ,colour, search icon, greeting phrase #37

Conversation

1-SubhamSingh
Copy link
Contributor

Related Issue

Issue : fix the hamburger menu

Fixes : #9

Before_fixes.mp4

Description of Changes

Changed the colour of the menu button , enhanced the animation of the menu button.
Fixed the bottom of the hamburger menu , adjusted its size by blocking its overflow.
Positioned the greeting phrase in the center to look good.
Moved the search button to the right with some padding which looks good on different screen sizes.
No fixed the top because the search icon would have hidden due to that.

After_fixes2.mp4

Type of Pull Request

  • [* ] Performance Improvement

Checklist for Contributor

use'X' in [ ] to check it .

  • [* ] I have reviewed my code before submission.
  • [* ] I have read and followed the project's Contribution Guidelines.
  • [* ] I have tested the code thoroughly.
  • [* ] I have attached related issue numbers, screenshots, or videos (if applicable).
  • [* ] I have checked the existing code base and my changes do not introduce any breaking changes.
  • [ *] My PR addresses only one issue; I have created separate PRs for other issues.
  • [* ] I have ensured that the PR does not include unrelated files.
  • [* ] I am mindful of the project's coding standards and best practices.

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
station-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 3:47pm

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Owner

@dhairyagothi dhairyagothi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just do this change other thing is perfect

}

width: 100vw;
overflow: hidden;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove it
Do overflow-x : hidden

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@dhairyagothi
Copy link
Owner

Perfect to go now @1-SubhamSingh good job

@dhairyagothi dhairyagothi merged commit 3a799c3 into dhairyagothi:main Oct 2, 2024
3 checks passed
Copy link
Contributor

github-actions bot commented Oct 2, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to Station Guide. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

@1-SubhamSingh
Copy link
Contributor Author

Thanks for the PR and also for updating the label to level 2 :))

@1-SubhamSingh 1-SubhamSingh deleted the feature/hamburger_fixed_other_minor_changes branch October 2, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc-ext GSSOX'24 Extended hacktoberfest-accepted Hacktoberfest level 2 25 Points Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making Hamburger function Properly
2 participants