Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Booking Confirmation #243

Merged
merged 11 commits into from
Oct 16, 2024
Merged

Conversation

haseebzaki-07
Copy link
Contributor

Pull Request Template for GSoC 2024

fixes #233

Description of Changes

This PR connects frontend bookings with the backend controllers and makes bookins for specific stations and stores the bookings info in the database. Also changed the UI of the bookings page to match with the desired purpose maintaining its aesthetics.

Type of Pull Request

  • Bug Fix
  • New Feature
  • Performance Improvement
  • Documentation Update
  • Code Refactoring
  • Security Enhancement
  • Other (Specify): _______________

(Please check relevant boxes by entering an "X" inside them)

Screenshots / Demo (if applicable)

2024-10-14.11-56-07.mp4

Checklist for Contributor

use'X' in [ ] to check it .

  • I have reviewed my code before submission.
  • I have read and followed the project's Contribution Guidelines.
  • I have tested the code thoroughly.
  • I have attached related issue numbers, screenshots, or videos (if applicable).
  • I have added comments to my code where necessary for clarity.
  • I have checked the existing code base and my changes do not introduce any breaking changes.
  • My PR addresses only one issue; I have created separate PRs for other issues.
  • I have ensured that the PR does not include unrelated files.
  • I am mindful of the project's coding standards and best practices.

Contribution Levels

  1. Task Categories:

    • Basic Tasks: Primarily focused on small changes like minor bug fixes, documentation improvements, and unit testing. Labeled as Easy.
    • Intermediate Tasks: Moderate-level tasks that involve enhancing existing features, code refactoring, or performance improvements. Labeled as Medium.
    • Advanced Tasks: Complex tasks like building new features, significant refactoring, or critical bug fixes. Labeled as Hard.
  2. Acknowledging Effort:

    • Exceptional contributions will be recognized with a higher contribution level if substantial effort and innovation are demonstrated.

Review Process

  • PRs will be reviewed by the maintainers, and feedback will be provided. Contributors should address feedback promptly and resubmit the PR if necessary.

  • Contributors are encouraged to participate in the review process of other PRs for community growth.

We appreciate your time and effort in improving this project and look forward to your valuable contributions!

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
station-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 5:22pm
station-guide-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 5:22pm

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@haseebzaki-07
Copy link
Contributor Author

Hey @dhairyagothi please increase the level of the PR as I also made significant changes in the UI components.

@dhairyagothi
Copy link
Owner

[13:21:40.289] Running build in Washington, D.C., USA (East) – iad1
[13:21:40.441] Cloning github.com/dhairyagothi/StationGuide (Branch: new_branch_%, Commit: 2926c0b)
[13:21:42.167] Cloning completed: 1.721s
[13:21:42.682] Restored build cache from previous deployment (8X1GXHADK8UPWmn4f7FVvXB2JBie)
[13:21:42.780] Running "vercel build"
[13:21:43.204] Vercel CLI 37.8.0
[13:21:44.261] Installing dependencies...
[13:21:48.309]
[13:21:48.310] added 8 packages, and removed 3 packages in 4s
[13:21:48.310]
[13:21:48.311] 164 packages are looking for funding
[13:21:48.311] run npm fund for details
[13:21:48.329] Running "npm run build"
[13:21:48.468]
[13:21:48.469] > station-saarthi@0.0.0 build
[13:21:48.469] > vite build
[13:21:48.469]
[13:21:48.651] /vercel/path0/frontend/node_modules/rollup/dist/native.js:59
[13:21:48.651] throw new Error(
[13:21:48.652] ^
[13:21:48.652]
[13:21:48.652] Error: Cannot find module @rollup/rollup-linux-x64-gnu. npm has a bug related to optional dependencies (npm/cli#4828). Please try npm i again after removing both package-lock.json and node_modules directory.
[13:21:48.652] at requireWithFriendlyError (/vercel/path0/frontend/node_modules/rollup/dist/native.js:59:9)
[13:21:48.652] at Object. (/vercel/path0/frontend/node_modules/rollup/dist/native.js:68:76)
[13:21:48.652] ... 3 lines matching cause stack trace ...
[13:21:48.653] at Module._load (node:internal/modules/cjs/loader:1104:12)
[13:21:48.653] at cjsLoader (node:internal/modules/esm/translators:346:17)
[13:21:48.653] at ModuleWrap. (node:internal/modules/esm/translators:286:7)
[13:21:48.653] at ModuleJob.run (node:internal/modules/esm/module_job:234:25)
[13:21:48.653] at async ModuleLoader.import (node:internal/modules/esm/loader:473:24) {
[13:21:48.653] [cause]: Error: Cannot find module '@rollup/rollup-linux-x64-gnu'
[13:21:48.653] Require stack:
[13:21:48.653] - /vercel/path0/frontend/node_modules/rollup/dist/native.js
[13:21:48.654] at Module._resolveFilename (node:internal/modules/cjs/loader:1225:15)
[13:21:48.654] at Module._load (node:internal/modules/cjs/loader:1051:27)
[13:21:48.654] at Module.require (node:internal/modules/cjs/loader:1311:19)
[13:21:48.654] at require (node:internal/modules/helpers:179:18)
[13:21:48.654] at requireWithFriendlyError (/vercel/path0/frontend/node_modules/rollup/dist/native.js:41:10)
[13:21:48.655] at Object. (/vercel/path0/frontend/node_modules/rollup/dist/native.js:68:76)
[13:21:48.655] at Module._compile (node:internal/modules/cjs/loader:1469:14)
[13:21:48.655] at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
[13:21:48.655] at Module.load (node:internal/modules/cjs/loader:1288:32)
[13:21:48.655] at Module._load (node:internal/modules/cjs/loader:1104:12) {
[13:21:48.655] code: 'MODULE_NOT_FOUND',
[13:21:48.656] requireStack: [ '/vercel/path0/frontend/node_modules/rollup/dist/native.js' ]
[13:21:48.656] }
[13:21:48.656] }
[13:21:48.656]
[13:21:48.656] Node.js v20.17.0
[13:21:48.671] Error: Command "npm run build" exited with 1
[13:21:49.132]

Screenshot 2024-10-15 094614

fix this deployment issues are there

@haseebzaki-07
Copy link
Contributor Author

hey @dhairyagothi I have fixed the errors

@dhairyagothi dhairyagothi added level 2 25 Points Issue gssoc-ext GSSOX'24 Extended hacktoberfest-accepted Hacktoberfest labels Oct 16, 2024
@dhairyagothi dhairyagothi merged commit b2741e8 into dhairyagothi:main Oct 16, 2024
4 checks passed
Copy link
Contributor

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to Station Guide. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext GSSOX'24 Extended hacktoberfest-accepted Hacktoberfest level 2 25 Points Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirm Bookings
2 participants