Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cloakroom and wheelchair booking backend routes #107

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

haseebzaki-07
Copy link
Contributor

Pull Request Template for GSoC 2024

Related Issue

fixes #103

Description of Changes

I have created models and controllers for WheelChair booking and Cloakroom booking.

Type of Pull Request

  • Bug Fix
  • [X ] New Feature
  • Performance Improvement
  • Documentation Update
  • Code Refactoring
  • Security Enhancement
  • Other (Specify): _______________

(Please check relevant boxes by entering an "X" inside them)

Screenshots / Demo (if applicable)

Screenshot 2024-10-07 152323

Screenshot 2024-10-07 153153

Checklist for Contributor

use 'X' in [ ] to check it .

  • [X ] I have reviewed my code before submission.
  • [X ] I have read and followed the project's Contribution Guidelines.
  • [X ] I have tested the code thoroughly.
  • [X ] I have attached related issue numbers, screenshots, or videos (if applicable).
  • I have added comments to my code where necessary for clarity.
  • [X ] I have checked the existing code base and my changes do not introduce any breaking changes.
  • [X ] My PR addresses only one issue; I have created separate PRs for other issues.
  • [X ] I have ensured that the PR does not include unrelated files.
  • [X ] I am mindful of the project's coding standards and best practices.

Additional Information

Contribution Guidelines Reminder

Thank you for contributing to our project! Please ensure you follow the guidelines below:

Contribution Levels

  1. Task Categories:

    • Basic Tasks: Primarily focused on small changes like minor bug fixes, documentation improvements, and unit testing. Labeled as Easy.
    • Intermediate Tasks: Moderate-level tasks that involve enhancing existing features, code refactoring, or performance improvements. Labeled as Medium.
    • Advanced Tasks: Complex tasks like building new features, significant refactoring, or critical bug fixes. Labeled as Hard.
  2. Acknowledging Effort:

    • Exceptional contributions will be recognized with a higher contribution level if substantial effort and innovation are demonstrated.

Review Process

  • PRs will be reviewed by the maintainers, and feedback will be provided. Contributors should address feedback promptly and resubmit the PR if necessary.

  • Contributors are encouraged to participate in the review process of other PRs for community growth.

We appreciate your time and effort in improving this project and look forward to your valuable contributions!

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
station-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 6:14pm
station-guide-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 6:14pm

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@dhairyagothi
Copy link
Owner

good @haseebzaki-07

please also add for coolie booking
check figma design

schemas

  • time
  • location (pickup)
  • location(depaurture)
    -price
  • station

@dhairyagothi dhairyagothi added dependencies Pull requests that update a dependency file gssoc-ext GSSOX'24 Extended hacktoberfest-accepted Hacktoberfest labels Oct 7, 2024
Copy link
Owner

@dhairyagothi dhairyagothi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do changes

@haseebzaki-07
Copy link
Contributor Author

Sure I will add the changes

@dhairyagothi
Copy link
Owner

@haseebzaki-07 please also share a SS

@haseebzaki-07
Copy link
Contributor Author

Hey @dhairyagothi I have added the coolie bookings backend
Screenshot 2024-10-07 234030

@dhairyagothi dhairyagothi self-requested a review October 8, 2024 15:49
@dhairyagothi dhairyagothi added the level 3 45 points issue label Oct 8, 2024
@dhairyagothi dhairyagothi merged commit 183e673 into dhairyagothi:main Oct 8, 2024
4 checks passed
Copy link
Contributor

github-actions bot commented Oct 8, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to Station Guide. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file gssoc-ext GSSOX'24 Extended hacktoberfest-accepted Hacktoberfest level 3 45 points issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Backend Issue]: Adding backend for booking
2 participants