Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix checkstyle #182

Merged
merged 13 commits into from
Oct 13, 2024
Merged

fix checkstyle #182

merged 13 commits into from
Oct 13, 2024

Conversation

dykov
Copy link
Collaborator

@dykov dykov commented Oct 13, 2024

Many thanks for your contribution, we truly appreciate it. We will appreciate it even more, if you make sure that you can say "YES" to each point in this short checklist:

  • You made a small amount of changes (less than 100 lines, less than 10 files)
  • You made changes related to only one bug (create separate PRs for separate problems)
  • You are ready to defend your changes (there will be a code review)
  • You don't touch what you don't understand
  • You ran the build locally and it passed

This article will help you understand what we are looking for: http://www.yegor256.com/2015/02/09/serious-code-reviewer.html

Thank you for your contribution!

@dykov dykov merged commit 5b99268 into dgroup:168-wip-pmd-7.x Oct 13, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant