Increase code quality thresholds

dgroup · Oct 14, 2024 · 4504dc3 · 4504dc3
1 parent 07fd531
commit 4504dc3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 13 deletions.
diff --git a/pom.xml b/pom.xml
@@ -103,13 +103,12 @@
     <jmh.version>1.37</jmh.version>
     <jmh.suite.name>arch4u-pmd-benchmarks</jmh.suite.name>
     <!-- Code quality -->
-    <!-- @todo #/DEV Increase quality thresholds once all tests are fixed    -->
-    <code.cvrg.classes-without-tests>3</code.cvrg.classes-without-tests>
-    <code.cvrg.instructions>0.8</code.cvrg.instructions>
-    <code.cvrg.complexity>0.6</code.cvrg.complexity>
-    <code.cvrg.methods>0.7</code.cvrg.methods>
-    <code.cvrg.branch>0.6</code.cvrg.branch>
-    <code.cvrg.line>0.8</code.cvrg.line>
+    <code.cvrg.classes-without-tests>0</code.cvrg.classes-without-tests>
+    <code.cvrg.instructions>0.9</code.cvrg.instructions>
+    <code.cvrg.complexity>0.8</code.cvrg.complexity>
+    <code.cvrg.methods>0.9</code.cvrg.methods>
+    <code.cvrg.branch>0.8</code.cvrg.branch>
+    <code.cvrg.line>0.9</code.cvrg.line>
     <sonar.projectKey>dgroup_arch4u-pmd</sonar.projectKey>
     <sonar.organization>dgroup-github</sonar.organization>
     <sonar.host.url>https://sonarcloud.io</sonar.host.url>

diff --git a/src/test/java/io/github/dgroup/arch4u/pmd/JUnitAssertionsShouldIncludeMessageTest.java b/src/test/java/io/github/dgroup/arch4u/pmd/JUnitAssertionsShouldIncludeMessageTest.java
@@ -30,15 +30,12 @@
  * Test case for {@code JUnitAssertionsShouldIncludeMessage} rule.
  *
  * @since 0.1.0
- * @checkstyle MethodBodyCommentsCheck (100 lines)
- * @checkstyle CommentsIndentationCheck (100 lines)
  */
 @SuppressWarnings({"PMD.TestClassWithoutTestCases", "PMD.JUnit4TestShouldUseBeforeAnnotation"})
 public final class JUnitAssertionsShouldIncludeMessageTest extends SimpleAggregatorTst {
 
     @Override
     public void setUp() {
-        // @todo #/DEV Implementation is needed
         addRule(
             "io/github/dgroup/arch4u/pmd/arch4u-ruleset.xml",
             "JUnitAssertionsShouldIncludeMessage"

diff --git a/src/test/java/io/github/dgroup/arch4u/pmd/UseExistingConstantTest.java b/src/test/java/io/github/dgroup/arch4u/pmd/UseExistingConstantTest.java
@@ -30,14 +30,11 @@
  * Test case for {@link UseExistingConstant} rule.
  *
  * @since 0.1.0
- * @checkstyle RegexpSinglelineCheck (100 lines)
- * @checkstyle MethodBodyCommentsCheck (100 lines)
  */
 @SuppressWarnings({"PMD.TestClassWithoutTestCases", "PMD.JUnit4TestShouldUseBeforeAnnotation"})
 public final class UseExistingConstantTest extends SimpleAggregatorTst {
     @Override
     public void setUp() {
-        // @todo #/DEV Implementation is required
         addRule("io/github/dgroup/arch4u/pmd/arch4u-ruleset.xml", "UseExistingMediaTypeConstant");
     }
 }