Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#837 is currently blocked because a new field in the
list_neurons
requests is breaking our tests. This PR unblocks it by updating the tests and exposing this new parameter.This PR addresses just the issues in the nns package.
Changes
14c8f44
./scripts/import-candid ../ic
from ic-js root folder./scripts/compile-idl-js
from ic-js root foldernns
packagefromListNeurons
typeneuron_subaccounts
throughlistNeurons
Tests
Todos