Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update nns Candid Files #838

Merged
merged 6 commits into from
Feb 10, 2025
Merged

chore: update nns Candid Files #838

merged 6 commits into from
Feb 10, 2025

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Feb 10, 2025

Motivation

#837 is currently blocked because a new field in the list_neurons requests is breaking our tests. This PR unblocks it by updating the tests and exposing this new parameter.

This PR addresses just the issues in the nns package.

Changes

  • Checkout ic at 14c8f44
  • Ran ./scripts/import-candid ../ic from ic-js root folder
  • Ran ./scripts/compile-idl-js from ic-js root folder
  • Revert changes not related to the nns package
  • Fix fromListNeurons type
  • Exposed neuron_subaccounts through listNeurons
  • Updated expectations for tests based on the new API

Tests

  • Should pass as before

Todos

  • Add entry to changelog (if necessary).

@yhabib yhabib changed the title Yhabib/candid 14c8f44 chore: update nns Candid Files Feb 10, 2025
Copy link
Contributor

github-actions bot commented Feb 10, 2025

size-limit report 📦

Path Size
@dfinity/ckbtc 8.12 KB (0%)
@dfinity/cketh 3.68 KB (0%)
@dfinity/cmc 1.41 KB (0%)
@dfinity/ledger-icrc 4.29 KB (0%)
@dfinity/ledger-icp 15.41 KB (0%)
@dfinity/nns 37.31 KB (+0.18% 🔺)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 17.19 KB (0%)
@dfinity/utils 4.71 KB (0%)
@dfinity/zod-schemas 626 B (0%)
@dfinity/ic-management 3.22 KB (0%)

@yhabib yhabib marked this pull request as ready for review February 10, 2025 08:29
@yhabib yhabib requested review from a team as code owners February 10, 2025 08:29
@dskloetd
Copy link
Collaborator

I don't see the changelog entry?

@yhabib yhabib merged commit d484d70 into main Feb 10, 2025
12 checks passed
@yhabib yhabib deleted the yhabib/candid-14c8f44 branch February 10, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants