fix: SDK-1341: Duplicate request error messages #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
as a 
ghost
changed the title
THLO
reviewed
Jan 16, 2024
THLO
reviewed
Jan 16, 2024
sesi200
reviewed
Jan 16, 2024
THLO
reviewed
Jan 17, 2024
THLO
reviewed
Jan 17, 2024
THLO
reviewed
Jan 17, 2024
THLO
reviewed
Jan 17, 2024
THLO
approved these changes
Jan 17, 2024
Co-authored-by: Thomas Locher <thomas.locher@dfinity.org>
Co-authored-by: Thomas Locher <thomas.locher@dfinity.org>
Co-authored-by: Thomas Locher <thomas.locher@dfinity.org>
Co-authored-by: Thomas Locher <thomas.locher@dfinity.org>
sesi200
approved these changes
Jan 17, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_canister, icrc1_transfer, and send return InsufficientFunds instead of Duplicate if a request is submitted twice. This PR changes order of checks, so that Duplicate error is returned. Also added tests covering basic cases for the affected endpoints
The incorrect error scenario may occur if the account in question has very low funds (transfer eats up most of them).
When you submit the transaction first time around, it updates your balance and then makes an async call. If at this state you resubmit transaction you might not have enough balance to pass the balance check (or expected_allowance might not match in case of approve). In such case you will get an InsufficientFunds error instead of DuplicateTransaction.
On the other hand you need to update the balance before that async call, otherwise you enter all sorts of double spending scenarios.