Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: extend RouteProvider trait with routes_stats() #629

Merged
merged 7 commits into from
Jan 27, 2025
Merged

chore: extend RouteProvider trait with routes_stats() #629

merged 7 commits into from
Jan 27, 2025
+97 −14

Conversation

nikolay-komarevskiy
Copy link
Contributor

@nikolay-komarevskiy nikolay-komarevskiy commented Jan 17, 2025 •
edited
Loading

Description

RouteProvider trait is extended with a method to get useful metrics about the total number of routes and healthy number of routes.

/// Returns statistics about the total number of existing routes and the number of healthy routes.
fn routes_stats(&self) -> RoutesStats;

How Has This Been Tested?

Unit tests were extended accordingly.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@nikolay-komarevskiy nikolay-komarevskiy force-pushed the komarevskiy/extend-route-provider-with-routes-stats branch from 84c8505 to bd59d8e Compare January 17, 2025 14:38
@nikolay-komarevskiy nikolay-komarevskiy marked this pull request as ready for review January 20, 2025 17:20
@nikolay-komarevskiy nikolay-komarevskiy requested a review from a team as a code owner January 20, 2025 17:20
@nikolay-komarevskiy nikolay-komarevskiy force-pushed the komarevskiy/extend-route-provider-with-routes-stats branch 2 times, most recently from ab05261 to 531acf4 Compare January 22, 2025 09:37
@nikolay-komarevskiy nikolay-komarevskiy force-pushed the komarevskiy/extend-route-provider-with-routes-stats branch from 531acf4 to 9ed0fe1 Compare January 22, 2025 09:38
ericswanson-dfinity
ericswanson-dfinity reviewed Jan 22, 2025
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
nikolay-komarevskiy and others added 2 commits January 23, 2025 15:35
@nikolay-komarevskiy
fix: missing docs
5641c79
@nikolay-komarevskiy @ericswanson-dfinity
Update CHANGELOG.md
0e5f803 
Co-authored-by: Eric Swanson <64809312+ericswanson-dfinity@users.noreply.github.com>
@adamspofford-dfinity adamspofford-dfinity merged commit c584390 into dfinity:main Jan 27, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blind-oracle blind-oracle blind-oracle approved these changes

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

@adamspofford-dfinity adamspofford-dfinity Awaiting requested review from adamspofford-dfinity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikolay-komarevskiy @blind-oracle @ericswanson-dfinity @adamspofford-dfinity