Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated unitcosts2025 #80

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Updated unitcosts2025 #80

merged 3 commits into from
Jan 29, 2025

Conversation

AStoker830
Copy link
Contributor

@AStoker830 AStoker830 commented Jan 29, 2025

Pull request overview

2023-24 unit costs have been updated with new S251 data.

Pull request checklist

Please check if your PR fulfills the following:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been run locally and are passing (shinytest2::test_app())
  • Code is styled according to tidyverse styling (checked locally with styler::style_dir() and lintr::lint_dir())

What is the current behaviour?

Unit costs annual update.

What is the new behaviour?

Costs data has been updated with new S251 data.

Anything else

Also updated new banner to note this. Feedback form added to the BETA banner line.

@AStoker830 AStoker830 requested a review from JT-39 January 29, 2025 15:18
#' This variable holds the path to the 'LAIT - modernisation' teams channel folder.
#' The folder is synchronised and located in the user's local system.
#'
shared_folder <- paste0(r"(C:\Users\)", Sys.info()[["user"]], r"(\Department for Education)", r"(\LA Data & Analysis - Children's Social Care - LAPD Private Sync)", r"(\LAIT\Information for App Development)")

Check notice

Code scanning / lintr

Lines should not be more than 120 characters. This line is 208 characters. Note

Lines should not be more than 120 characters. This line is 208 characters.
Copy link
Contributor

@JT-39 JT-39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with these, worked with Andrea to get these in.

@AStoker830 AStoker830 merged commit 75ffad4 into main Jan 29, 2025
3 checks passed
@AStoker830 AStoker830 deleted the updated-unitcosts2025 branch January 29, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants