Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
This is to fix issue #74 where the line chart tooltip is not in the correct order.
Pull request checklist
Please check if your PR fulfills the following:
shinytest2::test_app()
)styler::style_dir()
andlintr::lint_dir()
)What is the current behaviour?
When the tooltip contains values which have a suffix (such as million or billion) this is can currently lead to an incorrect order of the tooltip (for line charts). This is due to the order taking the raw number value of the formatted number (and not taking into account the suffix).
What is the new behaviour?
This issue has now been fixed, the tooltip is ordered by the raw value before the formatting.
Anything else
I had to update
{chromote}
to get a number of the tests to work due to an error that was appearing:I also had to run the line:
This came from a GitHub issue on the chromote repo- Chrome v132 no longer supports old headless mode #187