-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in test environment connections #54
Add in test environment connections #54
Conversation
…oss all endpoint functions
@rmbielby - test data sets are now published and can be viewed in the test data catalogue |
…set (cascades through to several other functions as well)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not my most concise review!
Commented with some ideas that could be put into future issues, plus a handful minor of things to actually address in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good to merge!
Brief overview of changes
This could get quite big. We need to add in the test environment examples, but also the environment needs to follow through appropriately in all the different components. And it'll be worth doing the same with api_version and dataset_version whilst we're on it.
Why are these changes being made?
We need eesyapi to work across multiple environments: dev, test, preprod, prod
Detailed description of changes
Environment and API version
environment
toees_environment
to avoid potential confusion with base R environment.ees_environment
andapi_version
through the function hierarchy:query_dataset()
->post_dataset()
->api_url()
api_url()
, at which point it will choose "test" if nothing's been set by the user onees_environment
and "1.0" if nothing's been set on api_version. Once we're working on prod I think we reverse that, so that all functions explicitly default to "prod", but the current set up just means we should be able to switch between dev, test, preprod and prod a little more easily where needed.example_id()
Function examples
Some function doc examples were hardwired with dev based codes. I've updated most of these to use
example_id()
instead to help make it a little easier to switch between platforms whilst we're developing.Issue ticket number/s and link
Resolves #39