Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper handling of NULL data return #55

Open
rmbielby opened this issue Oct 23, 2024 · 0 comments
Open

Add proper handling of NULL data return #55

rmbielby opened this issue Oct 23, 2024 · 0 comments
Labels
enhancement Improvement to existing feature things to test Specific aspects of our data to test the package can handle
Milestone

Comments

@rmbielby
Copy link
Contributor

Is your feature request related to a problem? Please describe.

If a query is legitimate in terms of what the API will accept, but there's just no data rows corresponding to the query terms, then the API returns a 200 response, but with no results. This gets pulled out as a NULL in post_dataset / get_dataset and the code errors with something like select not applicable to object NULL.

Examples of this are:

  • If the user requests a geographic level that's legitimate, but not present in the data set e.g. "SCH" in a data set only containing national data.

Describe the solution you'd like

A meaningful error message saying no data was found. Could even do a check on the obvious causes like "SCH is not found as a geographic level in this data file".

@rmbielby rmbielby added enhancement Improvement to existing feature things to test Specific aspects of our data to test the package can handle labels Oct 23, 2024
@rmbielby rmbielby added this to the Mop up sweep milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing feature things to test Specific aspects of our data to test the package can handle
Projects
None yet
Development

No branches or pull requests

1 participant