Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit for 7th MArch update #82

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Commit for 7th MArch update #82

merged 1 commit into from
Mar 7, 2024

Conversation

seankgibson
Copy link
Contributor

Pull request overview

Give a general description of why a change is being made, include issue number(s) being fixed if relevant

Pull request checklist

Please check if your PR fulfils the following:

  • [y ] Tests for the changes have been added (for bug fixes / features)
  • [y ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • [y ] Tests have been run locally and are passing (run_tests_locally())
  • [y ] Code is styled according to tidyverse styling (checked locally with tidy_code())

What is the current behaviour?

Dashboard up to date with data as at 22nd Feb update

What is the new behaviour?

Data updated to include up to 23rd Feb

Anything else

No additional notes

@seankgibson seankgibson requested a review from rmbielby March 7, 2024 08:57
@@ -86,7 +86,7 @@
br(),
h3("Coverage"),
p(textOutput("daily_schools_count")),
p("This number is approximately 88% of the number of schools participating in the School Census. As schools opt in to sharing of data, the number of schools reporting may change over time."),
p("This number is approximately 60% of the number of schools participating in the School Census. As schools opt in to sharing of data, the number of schools reporting may change over time. This figure is lower than in previous weeks due to some schools observing half term in the week commencing 19 February."),

Check notice

Code scanning / lintr

Lines should not be more than 80 characters. This line is 329 characters. Note

Lines should not be more than 80 characters. This line is 329 characters.
Copy link
Contributor

@rmbielby rmbielby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to note... I seem to remember the EES_*.csv files aren't used actively in the dashboard at all, so would be good to take those out of the updates at some point and just point users to EES for any download needs.

@seankgibson seankgibson merged commit d103b09 into main Mar 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants