Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update Go version #3913

Merged
merged 4 commits into from
Jan 21, 2025
+350 −81
Merged

build: update Go version #3913

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d066d8e
build: update Go version
sagikazarmark Jan 9, 2025
c7fd962
chore: fix linter config and violations
sagikazarmark Jan 9, 2025
3f7135b
fix: disable tls in tests
sagikazarmark Jan 9, 2025
c9da08e
ci: fix artifact build by disabling trivy cache update skip
sagikazarmark Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
fix: disable tls in tests 
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
@sagikazarmark
sagikazarmark committed Jan 9, 2025

Verified

This commit was signed with the committer’s verified signature.
sagikazarmark Márk Sági-Kazár
GPG key ID: 31AB0439F4C5C90E
Verified
Learn about vigilant mode
commit 3f7135b902b15292b2b22ad364a93ed41ef0d711
4 changes: 3 additions & 1 deletion storage/ent/mysql_test.go
View file
Original file line number Diff line number Diff line change
@@ -31,7 +31,9 @@ func mysqlTestConfig(host string, port uint64) *MySQL {
Port: uint16(port),
},
SSL: SSL{
Mode: mysqlSSLSkipVerify,
// This was originally mysqlSSLSkipVerify. It lead to handshake errors.
// See https://github.com/go-sql-driver/mysql/issues/1635 for more details.
Mode: mysqlSSLFalse,
},
params: map[string]string{
"innodb_lock_wait_timeout": "1",