Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxJS 6 / Angular 6 Compatiability #93

Open
isaackwan opened this issue May 6, 2018 · 5 comments
Open

RxJS 6 / Angular 6 Compatiability #93

isaackwan opened this issue May 6, 2018 · 5 comments

Comments

@isaackwan
Copy link

Hey there - thanks for your work on this! It really made my life much simplier.

However, I just wanted to give you a heads up on RxJS 6. They now have a slightly different import path, making this module not working on Angular 6+.

You can kind more details here:

@mtpultz
Copy link

mtpultz commented Jun 4, 2018

You can to fork the repository and replace all occurrences of rxjs/Subscription with rxjs in the /build folder, then just pull your fork down using npm instead of the original

@mattqs
Copy link

mattqs commented Jul 2, 2018

I made a version that works with Angular 6:
qs-angular2-busy

@deyvidfk
Copy link

Did not they think about the possibility of doing a pull-request with the implementation of compatibility with the "angular@^6"? It would help by giving continuity to the project and to those who already use this lib.

@jtc10005
Copy link

jtc10005 commented Oct 9, 2020

I am going to start working on getting this upgraded to support angular 6+. Im going to have to do it for work so might as well do it here so everyone will benefit.

@jtc10005
Copy link

I have got the library set up and demo site working using angular-cli. The repo is here, https://github.com/jtc10005/angular2-busy
But I am having trouble getting the busy.component to load the dynamic component. I dont have much experience with that, If anyone wants to take a look and povide some pointers I would appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants