feat: app status modal #2669
Open
feat: app status modal #2669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… related components - Removed AppStatusDetailModal and its associated type definitions. - Integrated AppStatusModal in AppDetails and EnvironmentStatusComponent for improved status display. - Updated modal props and handling to align with new structure. - Added ConfigDriftModal import for future use. - Minor style adjustments in base.scss for button radius.
AbhishekA1509
requested review from
vivek-devtron and
vikramdevtron
as code owners
github-actions
bot
added
the
PR:Issue-verification-failed
…sModal - Replaced inline title definitions in AppStatusModal with getAppStatusModalTitle for consistency across components. - Updated AppDetails, EnvironmentStatusComponent, and DevtronStackManager to use the new title function. - Cleaned up unused comments and improved code readability.
…ents - Combined environmentName and namespace for a more concise title in AppStatusModal. - Removed outdated comment regarding status text in DevtronStackManager.utils.ts for improved clarity.
- Set ENABLE_CI_JOB, ENABLE_CHART_SEARCH_IN_HELM_DEPLOY, HIDE_EXCLUDE_INCLUDE_GIT_COMMITS, ENABLE_BUILD_CONTEXT, FEATURE_USER_DEFINED_GITOPS_REPO_ENABLE, FEATURE_CONFIG_DRIFT_ENABLE, and FEATURE_SWAP_TRAFFIC_ENABLE to true in environment configuration. - Updated AppDetails component to correctly reference ConfigDriftModal. - Enhanced styling in AppStatusCard, IssuesCard, and SecurityVulnerabilityCard for improved UI consistency.
- Added new button states for deployed, uninstalling, pending install, pending upgrade, and pending rollback. - Updated existing states to include disconnect and superseded. - Adjusted color coding for updated, waiting, queued, missing, and unknown states for better visual distinction.
- Set HIDE_NETWORK_STATUS_INTERFACE to true in environment configuration for better user experience. - Refactored AppDetails component to utilize app details from IndexStore for improved data consistency. - Changed modal type in EnvironmentStatusComponent from 'external-apps' to 'other-apps' for better categorization. - Added appType to the return object in getAppDetailsFromResourceStatusData for enhanced data structure.
RohitRaj011
requested changes
Apr 25, 2025
| showAppStatusMessage={false} | ||
| showConfigDriftInfo={isConfigDriftEnabled} | ||
| <AppStatusModal | ||
| title={getAppStatusModalTitle([ |
There was a problem hiding this comment.
instead of this util can we move this into AppStatusModal?
or make a component for it?
RohitRaj011
previously approved these changes
Apr 29, 2025
feat: add new height utility class for 2px
vivek-devtron
previously approved these changes
Apr 29, 2025
… status filter container
…nto feat/app-status-modal
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Type of change
How Has This Been Tested?
QA
Checklist: