update icon: angularjs (plain) #2261
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] There are two problems with the plain svg: - The top of the 'A' consists of a lot of nodes that have a very complex outline, while in reality it should only be one sharp node - The 'A' outline is not closed [how] Remove superfluous nodes from outline and close it. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
changed the title
Snailedlt
previously approved these changes
Sep 12, 2024
Snailedlt
requested review from
a team,
ConX,
weh,
canaleal and
lunatic-fox
and removed request for
a team
canaleal
approved these changes
Oct 2, 2024
canaleal
changed the title
|
Hi! I'm the Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
There are two problems with the plain svg:
[how]
Remove superfluous nodes from outline and close it.
Double check these details before you open a PR
Features
General location of the problems:
Top of the 'A' shape, these are 10 nodes instead of 1 😬
Nodes 1 and 2 are not connected, note the missing direction arrow
This PR closes NONE
Notes
The non-closed outline breaks direct import into fontforge.
I did not check the other 3 angularjs icons, most likely they are there also.
@Snailedlt as per ryanoasis/nerd-fonts#1691 (comment)