Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: pug (original, plain, line) #2174

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

new icon: pug (original, plain, line) #2174

wants to merge 20 commits into from

Conversation

GCHQDeveloper926
Copy link

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

**This PR closes #567 **

Link to prove your SVG is correct and up-to-date.

(https://github.com/pugjs/pug-logo/blob/master/SVG/pug-final-logo-_-colour-128.svg)

@GCHQDeveloper926 GCHQDeveloper926 changed the base branch from master to develop March 28, 2024 13:59
@GCHQDeveloper926
Copy link
Author

GCHQDeveloper926 commented Mar 28, 2024 •
edited
Loading

First PR into here but hopefully have met all the required points.
Do I need to remove the title/formatting from original SVG that I've copied?

canaleal
canaleal requested changes Apr 21, 2024
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
icons/pug/pug-original.svg Show resolved Hide resolved
icons/pug/pug-plain.svg Show resolved Hide resolved
@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 1, 2024
@GCHQDeveloper926
Copy link
Author

Ok, Ive optimised the original icon and included the suggested plain and original from @Snailedlt . How is it looking now @canaleal - let me know if I need to optimise anything else

@GCHQDeveloper926 GCHQDeveloper926 changed the title new icon: pug (original, plain) new icon: pug (original, plain, line) Jul 3, 2024
Snailedlt
Snailedlt requested changes Jul 3, 2024
View reviewed changes
devicon.json Outdated Show resolved Hide resolved
icons/pug/pug-original.svg Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
GCHQDeveloper926 and others added 4 commits July 4, 2024 17:06
@GCHQDeveloper926 @Snailedlt
Update devicon.json
dbd37a9 
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@GCHQDeveloper926 @Snailedlt
Update devicon.json
3e5eaf3 
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Update original with new logo from pug site/comments
87d8dec
Merge branch 'icon/pug' of https://github.com/GCHQDeveloper926/devicon …
177ab92 
…into icon/pug
@GCHQDeveloper926
Copy link
Author

Anything further needed on this?

@Snailedlt Snailedlt requested review from a team, ConX, weh and lunatic-fox and removed request for a team August 14, 2024 06:51
weh
weh requested changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some really small things, other than that looks good to me

devicon.json Outdated Show resolved Hide resolved
icons/pug/pug-original.svg Outdated Show resolved Hide resolved
icons/pug/pug-line.svg Show resolved Hide resolved
icons/pug/pug-plain.svg Outdated Show resolved Hide resolved
fatihbaltaci and others added 3 commits September 4, 2024 03:15
@fatihbaltaci
Fix code block style
41c6828
@canaleal
Merge pull request devicons#2260 from fatihbaltaci/patch-1
ca28c77 
Fix code block style
@GCHQDeveloper926 @weh
Update devicon.json
ad5923d 
Co-authored-by: Patrik Wehrli <patrik.wehrli@gmail.com>
GCHQDeveloper926 and others added 2 commits September 11, 2024 16:19
@GCHQDeveloper926 @weh
Update icons/pug/pug-original.svg
cc9da04 
Co-authored-by: Patrik Wehrli <patrik.wehrli@gmail.com>
@GCHQDeveloper926 @weh
Update icons/pug/pug-plain.svg
95376e0 
Co-authored-by: Patrik Wehrli <patrik.wehrli@gmail.com>
@GCHQDeveloper926
Copy link
Author

Suggestions re newlines resolved, thanks @weh

Snailedlt
Snailedlt requested changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far!
Almost done!

icons/pug/pug-original.svg Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weh weh weh requested changes

@canaleal canaleal Awaiting requested review from canaleal

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers

@Snailedlt Snailedlt Awaiting requested review from Snailedlt

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon request: Pug
5 participants
@GCHQDeveloper926 @weh @Snailedlt @canaleal @fatihbaltaci