-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: StencilJS (original, original-wordmark) #2157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @gitChaoslord, great job! 👍
Just a couple of things to note:
- The names "stencil-original colored" and "wordmark colored" aren't valid SVG versions. Check the wiki for a list of valid names.
- Make sure the SVGs adhere to the SVG Standards.
It seems the official logo is the black version, so use that as the basis for "original" and "original-wordmark.svg".
Hello @canaleal, thank you! I've made some adjustments based on your input.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work 👍 Everything is almost ready.
Just 2 more changes:
The plain
and plain-wordmark
svgs need to have only 1 path. You can use the unify feature in inkscape to do this.
Great work using SVGOMG! For the final step, do the same but turn on all the feature options except:
- Remove xmlns
- Round/rewrite number lists
- Replace duplicate elements with lists
After optimizing, ensure that the svg code is one line long and includes a single empty line at the end.
Hello again @canaleal I've performed the requested changes as per your instructions
Let me know if there is anything else missing |
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM nothing to add here :)
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Double check these details before you open a PR
develop
branch.devicon.json
file at the correct alphabetic position as seen hereThis PR closes #866
Link to prove your SVG is correct and up-to-date.
The SVGs can be found here by downloading the "full press kit" at the bottom of page.
I've manipulated the downloaded SVGs using the following tools