-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new icon: biome (original, original-wordmark, plain-wordmark, line, line-wordmark) #2108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution and excellent work updating the json! I've marked down some changes.
To maintain a cohesive look, it would be good to update the line-wordmark
and line wordmark
fills with the #60a5fa
color used in the original.svg and plain-wordmark.svg.
The strokes in the line SVGs have to be updated to paths. In inkscape this an can be done by selecting all paths and then using the strokes > paths option.
The line-wordmark, plain-wordmark, and original-wordmark have to be scaled to reach the edges of the viewbox.
Hi @canaleal, thank you so much for reviewing my PR and for the detailed feedback! My apologies for the oversights. I've pushed changes to hopefully remedy all of the problem areas, but I'm happy to iterate further if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, no other major updates required!
I hope you don't mind but I optimized the SVGs to verify how they look on Icomoon.
Thankfully all icons look good and there are no artifacts.
Also, we use the following tutorial to optimize the SVGs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Awesome, I appreciate the help and guidance! Thank you so much for allowing me to contribute! |
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes #2107
Link to prove your SVG is correct and up-to-date.
Blog post introducing new logo: https://biomejs.dev/blog/roadmap-2024/#new-logo-and-homepage
Official Logo SVG:
Official Wordmark SVG: