From 570f6ac2a7dfc6da7826f8a77c5e445b0d0fb54c Mon Sep 17 00:00:00 2001 From: Clemens Bastian <8781699+amacado@users.noreply.github.com> Date: Tue, 23 Feb 2021 19:45:20 +0100 Subject: [PATCH 1/4] add environment for npm publish workflow (#513) --- .github/workflows/npm_publish.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/npm_publish.yml b/.github/workflows/npm_publish.yml index dfcadfdb6..554f8e5a1 100644 --- a/.github/workflows/npm_publish.yml +++ b/.github/workflows/npm_publish.yml @@ -3,6 +3,7 @@ on: types: [released] jobs: publish: + environment: release runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 From c841a95117b34dcb9223c4432d8b4d49c13e363c Mon Sep 17 00:00:00 2001 From: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> Date: Tue, 23 Feb 2021 13:58:23 -0800 Subject: [PATCH 2/4] Change the boolean in post_check_svgs_comment (#515) --- .github/workflows/post_check_svgs_comment.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/post_check_svgs_comment.yml b/.github/workflows/post_check_svgs_comment.yml index e7c9c32e0..cce4eba31 100644 --- a/.github/workflows/post_check_svgs_comment.yml +++ b/.github/workflows/post_check_svgs_comment.yml @@ -53,7 +53,7 @@ jobs: - name: Comment on the PR about the result - SVG Error uses: jungwinter/comment@v1 # let us comment on a specific PR - if: success() && (steps.err_message_reader.outputs.content != '0' || steps.err_message_reader.outputs.content != '1') + if: success() && (steps.err_message_reader.outputs.content != '0' && steps.err_message_reader.outputs.content != '1') env: MESSAGE: | Hi! From 376d617d7344c434e5c106f213f9cd25f86ef1b3 Mon Sep 17 00:00:00 2001 From: Clemens Bastian <8781699+amacado@users.noreply.github.com> Date: Wed, 24 Feb 2021 00:06:35 +0100 Subject: [PATCH 3/4] introducing teams and guidelines for supporters (#516) * introducing teams and guidelines for supporters * propose discussion as apply process for new members --- CONTRIBUTING.md | 37 +++++++++++++++++++++++++++++++++++++ README.md | 2 +- 2 files changed, 38 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 356797508..153cc06de 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -13,6 +13,7 @@ First of all, thanks for taking the time to contribute! This project can only gr
  • Updating the devicon.json
  • Example
  • Requesting An Icon
    • +
  • Maintainer/Reviewer/Teams
  • Regarding the Build Script
    • @@ -247,6 +248,42 @@ As an example, let's assume you have created the svgs for Redhat and Amazon Web
  • Optional: include links where the icon can be found
    • +
    +

    Maintainer/Reviewer/Teams

    +

    + Devicon is living by it's contributors and maintainers. Everyone can and is asked to contribute to this project. + You don't have to be in a team to contribute! +

    +

    + The branches master and develop are protected branches and only members + with corresponding permissions (see teams below) are able to push changes to them. + Additional branches must follow the pattern username/feature/description. + The /feature/ indicates that a change is made to existing code (regardless + if it's a fix, refactor or actual feature). The naming convention is based on the gitflow-workflow. +

    +

    For organisational purposes we introduced teams with permissions and responsibilities:

    +
    +
    Supporter (@devicons/supporter)
    +
    + Members of this team are responsible for reviewing pull request (auto assigned), managing issues and preparing the upcoming release.
    + Supporters have Write access to the repository (allowing them to create own branches) + and are allowed to push changes to the develop branch (pull request and status checks required). +
    +
    Maintainer (@devicons/maintainer)
    +
    + Maintainer role inherits from the 'Supporter' role and adds Maintainer permission + to the repository. + Members of this team are allowed to publish a new release (push master branch after pull + request and status checks). +
    +
    +

    + Wanna join the team? Please open a public discussion where + you introduce yourself.
    + New member requests have to be approved by all active members of the team Maintainer. Every member + of this team has a veto permission to reject a new member.
    +

    +

    Regarding The Build Script

    To make adding icons easier for repo maintainers, we rely on GitHub Actions, Python, Selenium, and Gulp to automate our tasks.

    diff --git a/README.md b/README.md index f9eaf40e8..160d27b9e 100644 --- a/README.md +++ b/README.md @@ -151,7 +151,7 @@ Add css rules in your stylesheet

    Contributing

    - We are happy for every contribution. Please have a look at our contribution guidelines + We are happy for every contribution. Please have a look at our contribution guidelines to see how you can contribute to this project.

    From 6e85c5d574c8027a0b22112a281930f513155ffb Mon Sep 17 00:00:00 2001 From: amacado Date: Wed, 24 Feb 2021 00:07:39 +0100 Subject: [PATCH 4/4] bump package version to 2.10.1 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 8ee977960..bfde6f698 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "devicon", - "version": "2.10.0", + "version": "2.10.1", "description": "Programming related icons collection", "main": "devicon.min.css", "scripts": {