Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project to use Go 1.22 #1369

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

dkwon17
Copy link
Collaborator

@dkwon17 dkwon17 commented Jan 8, 2025

What does this PR do?

Updates the project to use go 1.22.

What issues does this PR fix or reference?

Part of #1316

Is it tested? How?

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

@dkwon17 dkwon17 requested a review from ibuziuk as a code owner January 8, 2025 14:30
@openshift-ci openshift-ci bot added the approved label Jan 8, 2025
@@ -13,7 +13,7 @@
# limitations under the License.
#

FROM registry.ci.openshift.org/openshift/release:golang-1.20
FROM registry.ci.openshift.org/openshift/release:golang-1.22

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: containerImage not pinned by hash
Remediation tip: pin your Docker image by updating registry.ci.openshift.org/openshift/release to registry.ci.openshift.org/openshift/release@sha256:cd5c68457b9da02df266e32f9e26d9c323d808acaadc35126c50a526051c1d89
Click Remediation section below for further remediation help
@dkwon17 dkwon17 force-pushed the update-go-1.22 branch 3 times, most recently from 537ed78 to 54e9604 Compare February 15, 2025 03:39
Copy link

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkwon17, ibuziuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Feb 18, 2025
@dkwon17
Copy link
Collaborator Author

dkwon17 commented Feb 18, 2025

/retest

3 similar comments
@dkwon17
Copy link
Collaborator Author

dkwon17 commented Feb 18, 2025

/retest

@dkwon17
Copy link
Collaborator Author

dkwon17 commented Feb 19, 2025

/retest

@dkwon17
Copy link
Collaborator Author

dkwon17 commented Feb 19, 2025

/retest

Copy link

openshift-ci bot commented Feb 20, 2025

New changes are detected. LGTM label has been removed.

@dkwon17 dkwon17 mentioned this pull request Feb 20, 2025
3 tasks
Signed-off-by: David Kwon <dakwon@redhat.com>
Signed-off-by: David Kwon <dakwon@redhat.com>
Signed-off-by: David Kwon <dakwon@redhat.com>
Signed-off-by: David Kwon <dakwon@redhat.com>
Signed-off-by: David Kwon <dakwon@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants