-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CachingStore #247
Comments
I agree the caching would be nice, and would be a logical extension of the existing functionality. But caching gets really complex really quickly, and I don't want the full responsibility in this repo of managing that caching. Ideally I'd prefer that to be shipped as a standalone Python library, but given that So my suggestion would be to create a third party Rust repo ( |
I think your proposal makes sense. |
I don't have near-term availability to work on caching, but I could maybe review some PRs. @ion-elgreco would you be interested in setting up the repo and doing an initial implementation, borrowing for other existing implementations? |
I am a bit swamped in my weekends for the next 1-2 months. After that I should be able to support in dev time. In the mean time I can help with reviews though |
Alright. I started working on something and will ask you guys to take a look soon :) |
Was talking with @danielgafni on this. Would be nice if we can have a CachingStore, would work similarly to LimitStore, where we can wrap the inner store.
The CachingStore should be configurable with cache_size, tmp location and so forth.
I know there are a couple example implementations on this:
So perhaps we can add a general-purpose caching layer for immutable objects, and a version for potential mutable objects and a version for parquet specifically.
The text was updated successfully, but these errors were encountered: