Fixed all issues( #1 to #8) #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests - attempt2
sbmsr
reviewed
Apr 26, 2023
sbmsr
reviewed
Apr 26, 2023
sbmsr
reviewed
Apr 26, 2023
sbmsr
reviewed
Apr 26, 2023
sbmsr
reviewed
Apr 26, 2023
sbmsr
reviewed
Apr 26, 2023
sbmsr
reviewed
Apr 26, 2023
sbmsr
reviewed
Apr 26, 2023
Comment on lines
+11
to
+15
| filterOptions, | ||
| setFilterOptions, | ||
| sortOptions, | ||
| setSortOptions, | ||
| products, |
There was a problem hiding this comment.
suggestion: This is quite a lot of props coming in to this component. This usually indicates a smell. Check out how I fixed the functionality of this component here, without needing to add many props.
sbmsr
reviewed
Apr 26, 2023
sbmsr
reviewed
Apr 26, 2023
src/Components/ProductFilters.jsx
Outdated
Comment on lines
94
to
132
| filterOptions.price.forEach((element) => { | ||
| if (element.minValue.toString() === e.target.value) { | ||
| if (element.checked === false) { | ||
| element.checked = true; | ||
| } else if (element.checked === true) | ||
| element.checked = false; | ||
| } | ||
| }); | ||
| let selected_array = []; | ||
|
|
||
| let selected_products = filterOptions.price.filter( | ||
| function (x) { | ||
| return x.checked === true; | ||
| } | ||
| ); | ||
|
|
||
| selected_products.forEach((element) => { | ||
| selected_array.push( | ||
| allproducts.filter(function (item) { | ||
| return ( | ||
| item.price > element.minValue && | ||
| item.price < element.maxValue | ||
| ); | ||
| }) | ||
| ); | ||
| }); | ||
| if (selected_array.length > 0) { | ||
| setProducts(selected_array.flat(1)); | ||
| setselectedByPrice(selected_array.flat(1)); | ||
| } else { | ||
| if (selectedByColor.length > 0) { | ||
| setProducts(selectedByColor); | ||
| } else { | ||
| setProducts(allproducts); | ||
| setselectedByPrice(allproducts); | ||
| } | ||
| } | ||
|
|
||
| set_Nbr_Filters_price(selected_array.length); |
There was a problem hiding this comment.
suggestion: We should try and refactor this. It's quite a large chunk of code which is hard to maneuver at first glance.
I also notice its very similar to some of the code below (160 - 206). Given it's size right, it helps to isolate this to a single helper function, and then call it from the onClick handlers.
sbmsr
reviewed
Apr 26, 2023
sbmsr
reviewed
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, could you please review my changes. I fixed issues and added the new features as requested in issues#1 to 8. My previous PR failed the automated tests. This is a new one after attempting to resolve the issue.
Happy to discuss the changes if necessary.