optional cookie domain

desci-labs · Nov 9, 2023 · 6f8d596 · 6f8d596
1 parent f987ef8
commit 6f8d596
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/desci-server/src/controllers/auth/logout.ts b/desci-server/src/controllers/auth/logout.ts
@@ -14,7 +14,7 @@ export const logout = async (req: Request, res: Response, next: NextFunction) =>
     sameSite: 'strict',
   });
 
-  (process.env.COOKIE_DOMAIN.split(',') || [undefined]).map((domain) => {
+  (process.env.COOKIE_DOMAIN?.split(',') || [undefined]).map((domain) => {
     res.clearCookie('auth', {
       maxAge: oneYear,
       httpOnly: true, // Ineffective whilst we still return the bearer token to the client in the response

diff --git a/desci-server/src/utils/sendCookie.ts b/desci-server/src/utils/sendCookie.ts
@@ -4,7 +4,7 @@ import { oneDay, oneYear } from 'controllers/auth';
 import logger from 'logger';
 export const sendCookie = (res: Response, token: string, isDevMode: boolean) => {
   if (!isDevMode) {
-    (process.env.COOKIE_DOMAIN.split(',') || [undefined]).map((domain) => {
+    (process.env.COOKIE_DOMAIN?.split(',') || [undefined]).map((domain) => {
       res.cookie('auth', token, {
         maxAge: oneYear,
         httpOnly: true, // Ineffective whilst we still return the bearer token to the client in the response