Redis cache for stream commit state, dpid mappings, and legacy history structs #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kadamidev
approved these changes
Sep 17, 2024
| return res.status(400).send("Missing /:id or ids array in body"); | ||
| } else { | ||
| logger.info({ ids }, "Handling history query"); | ||
| logger.error({ body: req.body, params: req.params }, "request missing IDs"); |
There was a problem hiding this comment.
Maybe a .warn instead, no biggie
| const stream = await ceramic.loadStream(streamID); | ||
| const commitIds = stream.state.log.filter(({ type }) => type !== 2).map(({ cid }) => CommitID.make(streamID, cid)); | ||
|
|
||
| const versionPromises = commitIds.map(async (commit) => { |
There was a problem hiding this comment.
Fantastic, wonder if there's sense in rebumping the TTLs on cache hits if they're anchored
The data should no longer change at that state, and it would prevent a slow load after TTL expiry on that entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetches raw stream log to always get fresh tips, but uses redis to resolve the state of each commit.
Commits:
dPIDs and legacy history:
Speedup
Loading a node with a history of ~23 publishes goes from 5ish seconds to about 160ms 🎊 👯♀️