Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(style): synced stepper with pattern library #1251

Merged
merged 9 commits into from
Jan 23, 2024
Merged

fix(style): synced stepper with pattern library #1251

merged 9 commits into from
Jan 23, 2024

Conversation

orest-s
Copy link
Contributor

@orest-s orest-s commented Oct 19, 2023

Closes: #1052

@orest-s orest-s requested a review from a team as a code owner October 19, 2023 09:06
@github-actions
Copy link
Contributor

Preview branch generated at https://feat-sync-stepper-with-uxpin.d1gko6en628vir.amplifyapp.com

scurker
scurker requested changes Oct 24, 2023
View reviewed changes
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component looks good, just leaving a couple of nits and 1 requested change here.

packages/react/src/components/Stepper/index.tsx Outdated Show resolved Hide resolved
packages/react/src/components/Stepper/index.tsx Outdated Show resolved Hide resolved
packages/styles/stepper.css Outdated Show resolved Hide resolved
packages/styles/stepper.css Outdated Show resolved Hide resolved
packages/styles/stepper.css Outdated Show resolved Hide resolved
orest-s and others added 4 commits November 15, 2023 19:24
@orest-s @scurker
Update packages/react/src/components/Stepper/index.tsx
688ab98 
Co-authored-by: Jason <jason@scurker.com>
@orest-s @scurker
Update packages/react/src/components/Stepper/index.tsx
c3a79a1 
Co-authored-by: Jason <jason@scurker.com>
@orest-s @scurker
Update packages/styles/stepper.css
bd7a002 
Co-authored-by: Jason <jason@scurker.com>
@orest-s
fix: refactored code on new style and fixed minor nits with using ::b…
6f6081f 
…efore and --black var
@orest-s orest-s requested a review from scurker November 15, 2023 22:27
@scurker scurker closed this Nov 16, 2023
@scurker scurker reopened this Nov 16, 2023
@aws-amplify-us-east-1 AWS Amplify (us-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1251.d15792l1n26ww3.amplifyapp.com

scurker
scurker requested changes Nov 16, 2023
View reviewed changes
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component looks good, just one last change needed to update the em values.

packages/styles/stepper.css Outdated Show resolved Hide resolved
@scurker scurker merged commit 7c3f70b into develop Jan 23, 2024
6 checks passed
@scurker scurker deleted the feat/sync-stepper-with-uxpin branch January 23, 2024 21:02
@github-actions github-actions bot mentioned this pull request Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scurker scurker scurker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync Stepper with UXPin
2 participants
@orest-s @scurker