Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add button badge variant #1783

Open
dequejenn opened this issue Jan 3, 2025 · 2 comments · May be fixed by #1795
Open

Add button badge variant #1783

dequejenn opened this issue Jan 3, 2025 · 2 comments · May be fixed by #1795
Assignees
@stephenmathieson
Milestone
Q1 2025

Comments

@dequejenn
Copy link

dequejenn commented Jan 3, 2025 •
edited by stephenmathieson
Loading

figma designs

Add badge as an additional variant to the button component

Figma https://www.figma.com/design/CEFVdiecqDjLSjhorjHUzI/Product-Foundations-Library?node-id=810-3773

Similar example (implementing tag as button variant):
9a1593a

This would just be implementing the interactive states, not any additional things (such as the close icon).
@dequejenn dequejenn added this to the Q1 2025 milestone Jan 3, 2025
@stephenmathieson stephenmathieson self-assigned this Jan 23, 2025
@stephenmathieson
Copy link
Member

From Eric:

Button font sizes

stephenmathieson added a commit that referenced this issue Feb 3, 2025
@stephenmathieson
feat(button): Add "badge" variant
f03ec7e 
This patch adds a "badge" variant to our `<Button>` component.

Closes #1783
@stephenmathieson stephenmathieson linked a pull request Feb 3, 2025 that will close this issue
Open
@anastasialanz
Copy link
Contributor

anastasialanz commented Feb 4, 2025 •
edited
Loading

Should we also add "Badge" under "Related Components" on the "Button" page? @scurker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephenmathieson stephenmathieson

Labels
None yet
Projects
None yet
Milestone
Q1 2025
Development

Successfully merging a pull request may close this issue.

feat(button): Add "badge" variant dequelabs/cauldron
3 participants
@stephenmathieson @anastasialanz @dequejenn