refactor: 생년월일 입력 - 변경된 디자인 적용 및 리팩터링 #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doeunnkimm
requested review from
newminkyung,
hjy0951 and
deepbig
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
newminkyung
approved these changes
Apr 8, 2024
newminkyung
pushed a commit
that referenced
this pull request
Apr 26, 2024
* chore: DATE_SAPARATOR를 constants화 해서 사용 * refactor: 변경된 디자인 적용 및 기능 리팩터링 * chore: 정보수정 페이지에서 생년월일 부분 반영 * chore: default값으로 인해 붙는 separator를 예외시키기 위해 filter 메서드 추가 * fix: formattedValue가 format과 일치하는지 검사하는 검증 추가 * feat: member/new/birth에서 유효성 검증 추가
newminkyung
pushed a commit
that referenced
this pull request
Apr 26, 2024
* chore: DATE_SAPARATOR를 constants화 해서 사용 * refactor: 변경된 디자인 적용 및 기능 리팩터링 * chore: 정보수정 페이지에서 생년월일 부분 반영 * chore: default값으로 인해 붙는 separator를 예외시키기 위해 filter 메서드 추가 * fix: formattedValue가 format과 일치하는지 검사하는 검증 추가 * feat: member/new/birth에서 유효성 검증 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?
🎉 어떻게 해결했나요?
1. member/new/birth : 디자인 반영 및 유효성 검증 추가
2. 목표추가/date : 디자인 반영 및 유효성 검증 부분 리팩터링
3. my/update : 디자인 반영
📚 Attachment (Option)