update_code recipe - 3rd option update_code_strategy that loads submodule
#4063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cafferata
suggested changes
May 9, 2025
Co-authored-by: Jeffrey Cafferata <jeffrey@jcid.nl>
antonmedv
reviewed
May 10, 2025
| run("$git clone -l $bare ."); | ||
| run("$git remote set-url origin $repository", env: $env); | ||
| run("$git checkout --force $target"); | ||
| run("$git submodule init"); |
There was a problem hiding this comment.
Maybe it's better to define it as a separate task which can be attached if needed.
There was a problem hiding this comment.
I'm sorry, I'm not much into Deployer. I don't know how to solve this differently. Also, a separate task just for basically one line would be more complex.
There was a problem hiding this comment.
task('deploy:git:submodules', function () {
run('git submodule init');
run('git submodule update');
});There was a problem hiding this comment.
host('production')
->set('needs_submodules', true);
after('deploy:update_code', function () {
if (get('needs_submodules', false)) {
invoke('deploy:git:submodules');
}
});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to use submodules with
update_codeset toclonse_submodulewhile staying backwards compatible.Issue: #2802
Using submodules were possible in Deployer 6 but not 7 and could be reintroduced like this.