Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(biome): add support for json and jsonc #4805

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

redbmk
Copy link
Contributor

@redbmk redbmk commented Jul 8, 2024

  • adds biome linter for json and jsonc
  • enables biome by default for json and jsonc
  • suggests biome as a fixer for json and jsonc

I added some documentation to json and jsonc linting that just point to the typescript docs as the options and funcationality are all the same. This is what biome and deno are already doing in the javscript docs.

I didn't add any tests because I'm not really sure what I would be testing. Are there examples of testing that certain linters or fixers are enabled/suggested?

w0rp
w0rp previously approved these changes Jul 8, 2024
Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers! 🍻

@w0rp
Copy link
Member

w0rp commented Jul 8, 2024

One CI test failed, so have a look at that.

- adds biome linter for json and jsonc
- enables biome by default for json and jsonc
- suggests biome as a fixer for json and jsonc
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@hsanson hsanson merged commit 5c635d5 into dense-analysis:master Jul 9, 2024
7 checks passed
@redbmk redbmk deleted the biome-jsonc branch July 9, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants