Updated readme and tests.

preserve_case default value, description and tests.
denpamusic · Nov 15, 2018 · 5d7880e · 5d7880e
1 parent ed88a50
commit 5d7880e
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 13 deletions.
diff --git a/README.md b/README.md
@@ -45,12 +45,13 @@ or use array to define your bitcoind settings
 use Denpa\Bitcoin\Client as BitcoinClient;
 
 $bitcoind = new BitcoinClient([
-    'scheme'   => 'http',                 // optional, default http
-    'host'     => 'localhost',            // optional, default localhost
-    'port'     => 8332,                   // optional, default 8332
-    'user'     => 'rpcuser',              // required
-    'password' => 'rpcpassword',          // required
-    'ca'       => '/etc/ssl/ca-cert.pem'  // optional, for use with https scheme
+    'scheme'        => 'http',                 // optional, default http
+    'host'          => 'localhost',            // optional, default localhost
+    'port'          => 8332,                   // optional, default 8332
+    'user'          => 'rpcuser',              // required
+    'password'      => 'rpcpassword',          // required
+    'ca'            => '/etc/ssl/ca-cert.pem'  // optional, for use with https scheme
+    'preserve_case' => false,                  // optional, send method names as defined instead of lowercasing them
 ]);
 ```
 Then call methods defined in [Bitcoin Core API Documentation](https://bitcoin.org/en/developer-reference#bitcoin-core-apis) with magic:

diff --git a/src/Client.php b/src/Client.php
@@ -248,12 +248,13 @@ protected function onError(Exception $exception, callable $callback = null)
     protected function getDefaultConfig()
     {
         return [
-            'scheme'   => 'http',
-            'host'     => '127.0.0.1',
-            'port'     => 8332,
-            'user'     => '',
-            'password' => '',
-            'ca'       => null,
+            'scheme'        => 'http',
+            'host'          => '127.0.0.1',
+            'port'          => 8332,
+            'user'          => '',
+            'password'      => '',
+            'ca'            => null,
+            'preserve_case' => false,
         ];
     }
 
@@ -389,7 +390,8 @@ protected function makeJson($method, $params = [])
     {
         return [
             'json' => [
-                'method' => isset($this->config['preserve_case']) ? $method : strtolower($method),
+                'method' => $this->config['preserve_case'] ?
+                    $method : strtolower($method),
                 'params' => (array) $params,
                 'id'     => $this->rpcId++,
             ],

diff --git a/tests/ClientTest.php b/tests/ClientTest.php
@@ -125,6 +125,26 @@ public function testCaOption()
         $this->assertEquals(__FILE__, $bitcoind->getConfig('verify'));
     }
 
+    /**
+     * Test preserve method name case config option.
+     *
+     * @return void
+     */
+    public function testPreserveCase()
+    {
+        $bitcoind = new BitcoinClient(['preserve_case' => true]);
+        $bitcoind->setClient($this->mockGuzzle([$this->getBlockResponse()]));
+        $bitcoind->getBlockHeader();
+
+        $request = $this->getHistoryRequestBody();
+
+        $this->assertEquals(false, $bitcoind->getConfig('preserve_case'));
+        $this->assertEquals($this->makeRequestBody(
+            'getBlockHeader',
+            $request['id']
+        ), $request);
+    }
+
     /**
      * Test simple request.
      *