diff --git a/src/main/java/com/lalabrand/ecommerce/item/ItemRepository.java b/src/main/java/com/lalabrand/ecommerce/item/ItemRepository.java index d827830..5f9c1ed 100644 --- a/src/main/java/com/lalabrand/ecommerce/item/ItemRepository.java +++ b/src/main/java/com/lalabrand/ecommerce/item/ItemRepository.java @@ -9,6 +9,7 @@ import org.springframework.stereotype.Repository; import java.util.Collection; +import java.util.List; import java.util.Set; @Repository diff --git a/src/main/java/com/lalabrand/ecommerce/item/ItemService.java b/src/main/java/com/lalabrand/ecommerce/item/ItemService.java index 9cca4c6..7fcd8c4 100644 --- a/src/main/java/com/lalabrand/ecommerce/item/ItemService.java +++ b/src/main/java/com/lalabrand/ecommerce/item/ItemService.java @@ -39,8 +39,8 @@ public PageOfItems findItemsByTitle(String title, Language language, Pageable pa return PageOfItems.fromItemsPage(itemRepository.findByTitleContainingIgnoreCase(title, pageable)); } - public List findItemsByCategoryName(String categoryName, Pageable pageable) { - return convertToItemDtoList(itemRepository.findItemsByCategoryNameIgnoreCase(categoryName, pageable)); + public PageOfItems findItemsByCategoryName(String categoryName, Pageable pageable) { + return PageOfItems.fromItemsPage(itemRepository.findItemsByCategoryNameIgnoreCase(categoryName, pageable)); } public Item findItemByIdOrThrow(String itemId) { @@ -61,14 +61,6 @@ public Set findItemsByIdsOrThrow(Collection itemsIds) { return items; } - private List convertToItemDtoList(List items) { - List itemDTOList = new LinkedList<>(); - for (Item item : items) { - itemDTOList.add(ItemDTO.fromEntity(item)); - } - return itemDTOList; - } - public ItemDTO findById(String id) { Optional item = itemRepository.findById(id); if (item.isEmpty()) {