Updates

denomelchenko · Jul 18, 2024 · 037865c · 037865c
1 parent 124abae
commit 037865c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/src/main/java/com/lalabrand/ecommerce/item/ItemRepository.java b/src/main/java/com/lalabrand/ecommerce/item/ItemRepository.java
@@ -9,6 +9,7 @@
 import org.springframework.stereotype.Repository;
 
 import java.util.Collection;
+import java.util.List;
 import java.util.Set;
 
 @Repository

diff --git a/src/main/java/com/lalabrand/ecommerce/item/ItemService.java b/src/main/java/com/lalabrand/ecommerce/item/ItemService.java
@@ -39,8 +39,8 @@ public PageOfItems findItemsByTitle(String title, Language language, Pageable pa
         return PageOfItems.fromItemsPage(itemRepository.findByTitleContainingIgnoreCase(title, pageable));
     }
 
-    public List<ItemDTO> findItemsByCategoryName(String categoryName, Pageable pageable) {
-        return convertToItemDtoList(itemRepository.findItemsByCategoryNameIgnoreCase(categoryName, pageable));
+    public PageOfItems findItemsByCategoryName(String categoryName, Pageable pageable) {
+        return PageOfItems.fromItemsPage(itemRepository.findItemsByCategoryNameIgnoreCase(categoryName, pageable));
     }
 
     public Item findItemByIdOrThrow(String itemId) {
@@ -61,14 +61,6 @@ public Set<Item> findItemsByIdsOrThrow(Collection<String> itemsIds) {
         return items;
     }
 
-    private List<ItemDTO> convertToItemDtoList(List<Item> items) {
-        List<ItemDTO> itemDTOList = new LinkedList<>();
-        for (Item item : items) {
-            itemDTOList.add(ItemDTO.fromEntity(item));
-        }
-        return itemDTOList;
-    }
-
     public ItemDTO findById(String id) {
         Optional<Item> item = itemRepository.findById(id);
         if (item.isEmpty()) {